Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme generators always works in production mode #14228

Closed
mcollovati opened this issue Jul 28, 2022 · 2 comments · Fixed by #14230
Closed

Theme generators always works in production mode #14228

mcollovati opened this issue Jul 28, 2022 · 2 comments · Fixed by #14230
Labels
bug prerelease version for Vaadin 23.2.0 Released with Vaadin 23.1.6 Released with Vaadin 23.2.0.beta1 vite Tickets related to vite support
Projects
OLD Vaadin Flow bugs & maintenance (V...

Comments

@mcollovati
Copy link
Collaborator

Description of the bug

With Vite the theme-generator plugin always works in production mode, since the devMode = false is hard-coded in themeOptions.
This makes dev server fail to start when the styles.css is not present at startup.
In dev mode an empty file is created by the theme-generator plugin, but with Vite the flag is always true so the file is not generated and then the compilation fails.

Minimal reproducible example

Issue can be replicated running ThemeLiveReloadIT (flow-tests/test-application-theme/test-theme-live-reload) with Vite enabled

Expected behavior

styles.css is created and Vite compilation completes succesfully

Actual behavior

styles.css is not created and Vite compilation fails

Versions:

- Vaadin / Flow version: 23.2
- Java version: 11
- Development mode
- Test from Flow codebase
@mcollovati mcollovati added bug vite Tickets related to vite support labels Jul 28, 2022
@mcollovati mcollovati added this to Needs triage in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) via automation Jul 28, 2022
mcollovati added a commit that referenced this issue Jul 28, 2022
@mcollovati
fix: provide correct devMode flag to theme-generator with Vite
aa4c495 
devMode flag was hard-coded to false in theme options, preventing the theme generator
plugin to work correctly when styles.css does not exist

Fixes #14228
@mcollovati mcollovati mentioned this issue Jul 28, 2022
Merged
9 tasks
mshabarov pushed a commit that referenced this issue Jul 28, 2022
@mcollovati
fix: provide correct devMode flag to theme-generator with Vite (#14230)
5e18e24 
devMode flag was hard-coded to false in theme options, preventing the theme generator
plugin to work correctly when styles.css does not exist

Fixes #14228
OLD Vaadin Flow bugs & maintenance (Vaadin 10+) automation moved this from WIP to Closed Jul 28, 2022
vaadin-bot pushed a commit that referenced this issue Jul 28, 2022
@mcollovati @vaadin-bot
fix: provide correct devMode flag to theme-generator with Vite (#14230)
03bdfba 
devMode flag was hard-coded to false in theme options, preventing the theme generator
plugin to work correctly when styles.css does not exist

Fixes #14228
mcollovati pushed a commit that referenced this issue Jul 28, 2022
@vaadin-bot
fix: provide correct devMode flag to theme-generator with Vite (#14230)…
be28afc 
… (#14231)

devMode flag was hard-coded to false in theme options, preventing the theme generator
plugin to work correctly when styles.css does not exist

Fixes #14228
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.1.6.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.2.0.beta1 and is also targeting the upcoming stable 23.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug prerelease version for Vaadin 23.2.0 Released with Vaadin 23.1.6 Released with Vaadin 23.2.0.beta1 vite Tickets related to vite support
Projects
OLD Vaadin Flow bugs & maintenance (V...
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: provide correct devMode flag to theme-generator with Vite vaadin/flow
2 participants
@mcollovati @vaadin-bot