Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm taken from global installation instead of .vaadin installed #14839

Closed
caalador opened this issue Oct 14, 2022 · 1 comment · Fixed by #14840
Closed

npm taken from global installation instead of .vaadin installed #14839

caalador opened this issue Oct 14, 2022 · 1 comment · Fixed by #14840
Assignees
@caalador
Labels
bug Impact: High Released with Vaadin 23.2.6 Severity: Major
Projects
OLD Vaadin Flow bugs & maintenance (V...

Comments

@caalador
Copy link
Contributor

caalador commented Oct 14, 2022 •
edited

Description of the bug

[INFO] The globally installed Node.js version 14.19.0 is older than the required minimum version 16.14.0. Using Node.js from /root/.vaadin.
[DEBUG] Using node 16.17.1 located at /root/.vaadin/node/node
[DEBUG] Using npm 6.14.16 located at /usr/bin/npm

Expected behavior

As node is used as vaadin installed, then also npm is used from there and not the global one.

Minimal reproducible example

globall install old node, run application with 23.2-SNAPSHOT+

Versions

  • Vaadin / Flow version: 23.2+
  • OS: Unix
@caalador caalador added this to Needs triage in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) via automation Oct 14, 2022
@caalador caalador self-assigned this Oct 14, 2022
caalador added a commit that referenced this issue Oct 14, 2022
@caalador
fix: old node installation
556f42f 
Fix so that if we have a usable old
node installation we check the correc
path for npm script.

Fixes #14839
@caalador caalador mentioned this issue Oct 14, 2022
Merged
OLD Vaadin Flow bugs & maintenance (Vaadin 10+) automation moved this from WIP to Closed Oct 17, 2022
mshabarov pushed a commit that referenced this issue Oct 17, 2022
@caalador
fix: old node installation (#14840)
21dba87 
Fix so that if we have a usable old
node installation we check the correc
path for npm script.

Fixes #14839
vaadin-bot pushed a commit that referenced this issue Oct 17, 2022
@caalador @vaadin-bot
fix: old node installation (#14840)
e70b4fa 
Fix so that if we have a usable old
node installation we check the correc
path for npm script.

Fixes #14839
vaadin-bot pushed a commit that referenced this issue Oct 17, 2022
@caalador @vaadin-bot
fix: old node installation (#14840)
0cfbe05 
Fix so that if we have a usable old
node installation we check the correc
path for npm script.

Fixes #14839
caalador added a commit that referenced this issue Oct 17, 2022
@vaadin-bot @caalador
fix: old node installation (#14840) (#14863)
e8103dc 
Fix so that if we have a usable old
node installation we check the correc
path for npm script.

Fixes #14839

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
caalador added a commit that referenced this issue Oct 17, 2022
@vaadin-bot @caalador
fix: old node installation (#14840) (#14864)
7e058e6 
Fix so that if we have a usable old
node installation we check the correc
path for npm script.

Fixes #14839

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.2.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caalador caalador

Labels
bug Impact: High Released with Vaadin 23.2.6 Severity: Major
Projects
OLD Vaadin Flow bugs & maintenance (V...
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: old node installation vaadin/flow
2 participants
@caalador @vaadin-bot