Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a support for package custom theme for Express Build mode #15691

Closed
mshabarov opened this issue Jan 16, 2023 · 1 comment · Fixed by #15684
Closed

Add a support for package custom theme for Express Build mode #15691

mshabarov opened this issue Jan 16, 2023 · 1 comment · Fixed by #15684

Comments

@mshabarov
Copy link
Contributor

Custom themes packaged as a JAR dependency (parent theme and re-used theme) should work in Express Build mode.
Acceptance criteria:

Possible implementation details:

  • Flow needs to look at the frontend/generated/jar-resources/themes at build time and add the link tag to reference the styles.css on the page for each packaged theme.
  • Static file server should serve the CSS and assets defined in the packaged theme from frontend/generated/jar-resources/themes/my-packaged-theme.
  • Flow should spot an external assets included into packaged theme and trigger a new bundle generated to serve these assets from applicaiton bundle during the next runs.
@mshabarov mshabarov self-assigned this Jan 16, 2023
mshabarov added a commit that referenced this issue Jan 26, 2023
Serves styles and assets also for the packaged custom theme available from frontend/generated/jar-resources/themes
Calculates the hash of the theme.json for the packaged theme and records it to the bundle's stats.json
Checks if the hashes from the packaged themes match the corresponding hashes in the stats.json
Rebuilds the bundle if the packaged themes are added/updated (hashes don't match).

Fixes #15691
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha10 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants