Hot CSS replacement is broken when theme is injected in shadow roots in Safari #16909
Labels
Comments
mshabarov
added this to Needs triage
in OLD Vaadin Flow bugs & maintenance (Vaadin 10+)
via automation
mshabarov
moved this from Needs triage
to P1 - High priority
in OLD Vaadin Flow bugs & maintenance (Vaadin 10+)
|
This seems to be a manifestation of https://bugs.webkit.org/show_bug.cgi?id=254844 as the problem is that new style sheets are never added to The size of |
Artur-
added a commit
that referenced
this issue
May 30, 2023
mshabarov
pushed a commit
that referenced
this issue
May 31, 2023
OLD Vaadin Flow bugs & maintenance (Vaadin 10+)
automation
moved this from P1 - High priority
to Closed
May 31, 2023
vaadin-bot
pushed a commit
that referenced
this issue
May 31, 2023
vaadin-bot
added a commit
that referenced
this issue
May 31, 2023
Workaround for https://bugs.webkit.org/show_bug.cgi?id=254844 Fixes #16909 Co-authored-by: Artur <artur@vaadin.com>
|
This ticket/PR has been released with Vaadin 24.1.0. |
|
This ticket/PR has been released with Vaadin 24.2.0.alpha1 and is also targeting the upcoming stable 24.2.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the bug
When you open start.vaadin.com in Safari it looks like
When you do
touch styles.cssin the themes folder, you getIt seems like most of the adopted stylesheets for shadow roots go missing, e.g. the shadow root of
<view-item>has 9 adopted style sheets before the update and only 1 afterwards. Lumo utility classes are no longer available inside the shadow root, which changes font sizes and a lot of other things.Expected behavior
It stays the same
Minimal reproducible example
See the Start project
Versions
The text was updated successfully, but these errors were encountered: