Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme and jar file watching from other Maven modules does not work in Wildfly #17159

Open
Artur- opened this issue Jul 3, 2023 · 3 comments · May be fixed by #19322
Open

Theme and jar file watching from other Maven modules does not work in Wildfly #17159

Artur- opened this issue Jul 3, 2023 · 3 comments · May be fixed by #19322

Comments

@Artur-
Copy link
Member

Artur- commented Jul 3, 2023

Description of the bug

If you deploy a multi module project to Wildfly, then editing the frontend or theme files in another module than the main module will not trigger a live reload or hot deploy.

The problem is that the file watcher is not triggered on file changes. This seems to be caused by gmethvin/directory-watcher#94

Expected behavior

It should work like in all other servers

Minimal reproducible example

Need to create one

Versions

  • Vaadin / Flow version: 24.1.1
@Artur-
Copy link
Member Author

Artur- commented Jul 3, 2023

Workaround is to add com.sun.nio.file as a dependency, e.g.

            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-war-plugin</artifactId>
                <configuration>
                    <archive>
                        <manifestEntries>
                            <Dependencies>jdk.unsupported</Dependencies>
                        </manifestEntries>
                    </archive>
                </configuration>
            </plugin>

@AB-xdev
Copy link

AB-xdev commented Nov 13, 2023

Can confirm the problem for Vaadin 24, Wildfly 30 and Java 17 (Temurin)

@mcollovati
Copy link
Collaborator

It appears that adding the manifest entry to vaadin-dev-server works as well.

mcollovati added a commit that referenced this issue May 7, 2024
Adds the Dependencies manifest entry to the vaadin-dev-server artifact
to prevent runtime errors raised by FileWatcher when application is
deployed in Wildfly.

Fixes #17159
Fixes vaadin/cdi#636
mcollovati added a commit that referenced this issue May 7, 2024
Adds the Dependencies manifest entry to the vaadin-dev-server artifact
to prevent runtime errors raised by FileWatcher when application is
deployed in Wildfly.

Fixes #17159
Fixes vaadin/skeleton-starter-flow-cdi#636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔖 Normal Priority (P2)
Development

Successfully merging a pull request may close this issue.

3 participants