Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling sync id checking does not work #17237

Closed
TatuLund opened this issue Jul 19, 2023 · 0 comments · Fixed by #17238
Closed

Disabling sync id checking does not work #17237

TatuLund opened this issue Jul 19, 2023 · 0 comments · Fixed by #17238

Comments

@TatuLund
Copy link
Contributor

TatuLund commented Jul 19, 2023

Description of the bug

This bug fix does not take into account the case that lastSeenOnClient can be -1 when sync id checking has been disabled

https://github.com/vaadin/flow/pull/15764/files

This will result putting all messages back into cache repeatedly as alreadySeen returns always false.

This again leads to server continuously pushing.

See also trace log

2023-07-19 11:04:23.796 TRACE 22348 --- [nio-8080-exec-9] org.atmosphere.cpr.DefaultBroadcaster    : Checking cached message for 8fe751c1-6c2f-4f80-887b-33c424b979d2
2023-07-19 11:04:23.796 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Retrieved for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages 19
2023-07-19 11:04:23.796 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Available cached message {55e5b91a-a6f7-45f9-b520-068198745500=[], d996329d-ce61-4ccf-ab8f-8469f033da5f=[], 0c41ed78-5a39-42e3-92a0-cde48df50512=[com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@2687c99f, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@21528171, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@21528171, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@523eacb5, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@523eacb5, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@505133df, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@505133df, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@45e1c305, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@45e1c305, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@12bc7c37, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@12bc7c37, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@579acdc4, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@579acdc4, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@3e0e36b7, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@3e0e36b7, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@656ccd57, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@656ccd57, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@7055c2b1, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@7055c2b1, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@5924ca00, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@5924ca00]}
2023-07-19 11:04:23.800 DEBUG 22348 --- [nio-8080-exec-9] org.atmosphere.cpr.DefaultBroadcaster    : Sending cached message [com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@45306c44, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@13f71208, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@13f71208, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@21fe9185, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@21fe9185, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@4921d5e0, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@4921d5e0, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@51db79e7, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@51db79e7, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@1b157d51, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@1b157d51, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@70844800, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@70844800, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@7d45b3bf, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@7d45b3bf, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@5749dec, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@5749dec, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@4debe2d0, com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@4debe2d0] to 8fe751c1-6c2f-4f80-887b-33c424b979d2
2023-07-19 11:04:23.800 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 1 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":1,"addNodes":[7]},{"node":6,"type":"attach"},{"node":6,"type":"put","key":"text","feat":7,"value":"This is update 0"},{"node":7,"type":"attach"},{"node":7,"type":"put","key":"tag","feat":0,"value":"span"},{"node":7,"type":"clear","feat":2},{"node":7,"type":"splice","feat":2,"index":0,"addNodes":[6]}],"timings":[1126,1]}]
2023-07-19 11:04:23.800 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@45306c44
2023-07-19 11:04:23.800 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863796}
2023-07-19 11:04:23.800 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 2 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":2,"addNodes":[9]},{"node":8,"type":"attach"},{"node":8,"type":"put","key":"text","feat":7,"value":"This is update 1"},{"node":9,"type":"attach"},{"node":9,"type":"put","key":"tag","feat":0,"value":"span"},{"node":9,"type":"clear","feat":2},{"node":9,"type":"splice","feat":2,"index":0,"addNodes":[8]}],"timings":[1135,4]}]
2023-07-19 11:04:23.800 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@13f71208
2023-07-19 11:04:23.800 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863800}
2023-07-19 11:04:23.800 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 2 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":2,"addNodes":[9]},{"node":8,"type":"attach"},{"node":8,"type":"put","key":"text","feat":7,"value":"This is update 1"},{"node":9,"type":"attach"},{"node":9,"type":"put","key":"tag","feat":0,"value":"span"},{"node":9,"type":"clear","feat":2},{"node":9,"type":"splice","feat":2,"index":0,"addNodes":[8]}],"timings":[1135,4]}]
2023-07-19 11:04:23.800 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@13f71208
2023-07-19 11:04:23.800 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863800}
2023-07-19 11:04:23.800 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 3 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":3,"addNodes":[11]},{"node":10,"type":"attach"},{"node":10,"type":"put","key":"text","feat":7,"value":"This is update 2"},{"node":11,"type":"attach"},{"node":11,"type":"put","key":"tag","feat":0,"value":"span"},{"node":11,"type":"clear","feat":2},{"node":11,"type":"splice","feat":2,"index":0,"addNodes":[10]}],"timings":[1135,4]}]
2023-07-19 11:04:23.800 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@21fe9185
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863800}
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 3 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":3,"addNodes":[11]},{"node":10,"type":"attach"},{"node":10,"type":"put","key":"text","feat":7,"value":"This is update 2"},{"node":11,"type":"attach"},{"node":11,"type":"put","key":"tag","feat":0,"value":"span"},{"node":11,"type":"clear","feat":2},{"node":11,"type":"splice","feat":2,"index":0,"addNodes":[10]}],"timings":[1135,4]}]
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@21fe9185
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863801}
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 4 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":4,"addNodes":[13]},{"node":12,"type":"attach"},{"node":12,"type":"put","key":"text","feat":7,"value":"This is update 3"},{"node":13,"type":"attach"},{"node":13,"type":"put","key":"tag","feat":0,"value":"span"},{"node":13,"type":"clear","feat":2},{"node":13,"type":"splice","feat":2,"index":0,"addNodes":[12]}],"timings":[1135,4]}]
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@4921d5e0
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863801}
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 4 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":4,"addNodes":[13]},{"node":12,"type":"attach"},{"node":12,"type":"put","key":"text","feat":7,"value":"This is update 3"},{"node":13,"type":"attach"},{"node":13,"type":"put","key":"tag","feat":0,"value":"span"},{"node":13,"type":"clear","feat":2},{"node":13,"type":"splice","feat":2,"index":0,"addNodes":[12]}],"timings":[1135,4]}]
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@4921d5e0
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863801}
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 5 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":5,"addNodes":[15]},{"node":14,"type":"attach"},{"node":14,"type":"put","key":"text","feat":7,"value":"This is update 4"},{"node":15,"type":"attach"},{"node":15,"type":"put","key":"tag","feat":0,"value":"span"},{"node":15,"type":"clear","feat":2},{"node":15,"type":"splice","feat":2,"index":0,"addNodes":[14]}],"timings":[1135,4]}]
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@51db79e7
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863801}
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 5 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":5,"addNodes":[15]},{"node":14,"type":"attach"},{"node":14,"type":"put","key":"text","feat":7,"value":"This is update 4"},{"node":15,"type":"attach"},{"node":15,"type":"put","key":"tag","feat":0,"value":"span"},{"node":15,"type":"clear","feat":2},{"node":15,"type":"splice","feat":2,"index":0,"addNodes":[14]}],"timings":[1135,4]}]
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@51db79e7
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863801}
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 6 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":6,"addNodes":[17]},{"node":16,"type":"attach"},{"node":16,"type":"put","key":"text","feat":7,"value":"This is update 5"},{"node":17,"type":"attach"},{"node":17,"type":"put","key":"tag","feat":0,"value":"span"},{"node":17,"type":"clear","feat":2},{"node":17,"type":"splice","feat":2,"index":0,"addNodes":[16]}],"timings":[1135,4]}]
2023-07-19 11:04:23.801 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@1b157d51
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863801}
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 6 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":6,"addNodes":[17]},{"node":16,"type":"attach"},{"node":16,"type":"put","key":"text","feat":7,"value":"This is update 5"},{"node":17,"type":"attach"},{"node":17,"type":"put","key":"tag","feat":0,"value":"span"},{"node":17,"type":"clear","feat":2},{"node":17,"type":"splice","feat":2,"index":0,"addNodes":[16]}],"timings":[1135,4]}]
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@1b157d51
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863802}
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 7 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":7,"addNodes":[19]},{"node":18,"type":"attach"},{"node":18,"type":"put","key":"text","feat":7,"value":"This is update 6"},{"node":19,"type":"attach"},{"node":19,"type":"put","key":"tag","feat":0,"value":"span"},{"node":19,"type":"clear","feat":2},{"node":19,"type":"splice","feat":2,"index":0,"addNodes":[18]}],"timings":[1135,4]}]
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@70844800
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863802}
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 7 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":7,"addNodes":[19]},{"node":18,"type":"attach"},{"node":18,"type":"put","key":"text","feat":7,"value":"This is update 6"},{"node":19,"type":"attach"},{"node":19,"type":"put","key":"tag","feat":0,"value":"span"},{"node":19,"type":"clear","feat":2},{"node":19,"type":"splice","feat":2,"index":0,"addNodes":[18]}],"timings":[1135,4]}]
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@70844800
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863802}
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 8 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":8,"addNodes":[21]},{"node":20,"type":"attach"},{"node":20,"type":"put","key":"text","feat":7,"value":"This is update 7"},{"node":21,"type":"attach"},{"node":21,"type":"put","key":"tag","feat":0,"value":"span"},{"node":21,"type":"clear","feat":2},{"node":21,"type":"splice","feat":2,"index":0,"addNodes":[20]}],"timings":[1267,5]}]
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@7d45b3bf
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863802}
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 8 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":8,"addNodes":[21]},{"node":20,"type":"attach"},{"node":20,"type":"put","key":"text","feat":7,"value":"This is update 7"},{"node":21,"type":"attach"},{"node":21,"type":"put","key":"tag","feat":0,"value":"span"},{"node":21,"type":"clear","feat":2},{"node":21,"type":"splice","feat":2,"index":0,"addNodes":[20]}],"timings":[1267,5]}]
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@7d45b3bf
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863802}
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 9 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":9,"addNodes":[23]},{"node":22,"type":"attach"},{"node":22,"type":"put","key":"text","feat":7,"value":"This is update 8"},{"node":23,"type":"attach"},{"node":23,"type":"put","key":"tag","feat":0,"value":"span"},{"node":23,"type":"clear","feat":2},{"node":23,"type":"splice","feat":2,"index":0,"addNodes":[22]}],"timings":[1344,6]}]
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@5749dec
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863802}
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 9 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":9,"addNodes":[23]},{"node":22,"type":"attach"},{"node":22,"type":"put","key":"text","feat":7,"value":"This is update 8"},{"node":23,"type":"attach"},{"node":23,"type":"put","key":"tag","feat":0,"value":"span"},{"node":23,"type":"clear","feat":2},{"node":23,"type":"splice","feat":2,"index":0,"addNodes":[22]}],"timings":[1344,6]}]
2023-07-19 11:04:23.802 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@5749dec
2023-07-19 11:04:23.803 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863802}
2023-07-19 11:04:23.803 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 10 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":10,"addNodes":[25]},{"node":3,"type":"splice","feat":2,"index":11,"addNodes":[27]},{"node":24,"type":"attach"},{"node":24,"type":"put","key":"text","feat":7,"value":"This is update 9"},{"node":25,"type":"attach"},{"node":25,"type":"put","key":"tag","feat":0,"value":"span"},{"node":25,"type":"clear","feat":2},{"node":25,"type":"splice","feat":2,"index":0,"addNodes":[24]},{"node":26,"type":"attach"},{"node":26,"type":"put","key":"text","feat":7,"value":"Done updating"},{"node":27,"type":"attach"},{"node":27,"type":"put","key":"tag","feat":0,"value":"span"},{"node":27,"type":"clear","feat":2},{"node":27,"type":"splice","feat":2,"index":0,"addNodes":[26]}],"timings":[1527,4]}]
2023-07-19 11:04:23.803 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@4debe2d0
2023-07-19 11:04:23.803 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863803}
2023-07-19 11:04:23.803 TRACE 22348 --- [nio-8080-exec-9] c.v.f.s.c.LongPollingCacheFilter         : Put message 10 for resource 8fe751c1-6c2f-4f80-887b-33c424b979d2 back to the cache because it may not have reached the client, as the last seen message is -1. for(;;);[{"syncId":-1,"clientId":0,"meta":{"async":true},"changes":[{"node":3,"type":"splice","feat":2,"index":10,"addNodes":[25]},{"node":3,"type":"splice","feat":2,"index":11,"addNodes":[27]},{"node":24,"type":"attach"},{"node":24,"type":"put","key":"text","feat":7,"value":"This is update 9"},{"node":25,"type":"attach"},{"node":25,"type":"put","key":"tag","feat":0,"value":"span"},{"node":25,"type":"clear","feat":2},{"node":25,"type":"splice","feat":2,"index":0,"addNodes":[24]},{"node":26,"type":"attach"},{"node":26,"type":"put","key":"text","feat":7,"value":"Done updating"},{"node":27,"type":"attach"},{"node":27,"type":"put","key":"tag","feat":0,"value":"span"},{"node":27,"type":"clear","feat":2},{"node":27,"type":"splice","feat":2,"index":0,"addNodes":[26]}],"timings":[1527,4]}]
2023-07-19 11:04:23.803 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Adding for AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 cached messages com.vaadin.flow.server.communication.AtmospherePushConnection$PushMessage@4debe2d0
2023-07-19 11:04:23.803 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cache.UUIDBroadcasterCache  : Active clients {55e5b91a-a6f7-45f9-b520-068198745500=1689753795276, d996329d-ce61-4ccf-ab8f-8469f033da5f=1689753850343, 0c41ed78-5a39-42e3-92a0-cde48df50512=1689753804288, 8fe751c1-6c2f-4f80-887b-33c424b979d2=1689753863803}
2023-07-19 11:04:23.803 TRACE 22348 --- [nio-8080-exec-9] org.atmosphere.cpr.DefaultBroadcaster    : /* is broadcasting to 8fe751c1-6c2f-4f80-887b-33c424b979d2
2023-07-19 11:04:23.804 TRACE 22348 --- [nio-8080-exec-9] o.atmosphere.cpr.AtmosphereResourceImpl  : AtmosphereResource 8fe751c1-6c2f-4f80-887b-33c424b979d2 is resuming

Expected behavior

Disabling sync id checking should work

Minimal reproducible example

todo_with_push.zip

Versions

  • Vaadin / Flow version: 14, 23 and 24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants