fix: Fix regression when sync id check is disabled

[TatuLund]

Fixes: #17237

[sonatype-lift]

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

[github-actions]

Test Results

   998 files  ±0     998 suites  ±0   1h 0m 53s ⏱️ + 1m 4s
6 350 tests +1  6 309 ✔️ +1  41 💤 ±0  0 ❌ ±0 
6 609 runs  +6  6 561 ✔️ +6  48 💤 ±0  0 ❌ ±0 

Results for commit 5324be8. ± Comparison against base commit 9e0ef2f.

♻️ This comment has been updated with latest results.

[mcollovati]

@TatuLund thank you very much for spotting the bug and providing the fix.
The change looks good to me, but I would like to add a test for this case

Could use please add a test to LongPollingCacheFilterTest class?
Something like

    @Test
    public void filter_syncIdCheckDisabled_continueWithCurrentMessage() {
        // a value of -1 means that syncId check is disabled
        setSeenServerSyncIdHeader(-1);
        setTransport(AtmosphereResource.TRANSPORT.LONG_POLLING);
        simulatePushConnection();
        BroadcastAction action = filter.filter("broadcasterId", resource,
                originalMessage, message);
        Assert.assertEquals(ACTION.CONTINUE, action.action());
        Assert.assertSame(
                "Message should not be altered by filter if syncId check is disabled",
                message, action.message());
        verifyMessageIsNotCached();
    }

[TatuLund]

Could use please add a test to LongPollingCacheFilterTest class?

I was already working on that, now there

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.2.0.alpha5 and is also targeting the upcoming stable 24.2.0 version.