Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move /frontend directory under /src/main by default #18436

Closed
tarekoraby opened this issue Jan 11, 2024 · 2 comments
Closed

Move /frontend directory under /src/main by default #18436

tarekoraby opened this issue Jan 11, 2024 · 2 comments
Assignees
@caalador
Labels
enhancement Released with Vaadin 24.4.0

Comments

@tarekoraby
Copy link
Contributor

Describe your motivation

The standard directory layout of Maven/Gradle projects involves adding source files under src/main. However, Vaadin (especially when used with Hilla) currently requires adding JS/TS source files under /frontend.

Describe the solution you'd like

Consider moving the /frontend folder under src/main as a default. For backward compatibility, the current location of the /frontend folder at the project root can remain supported.
@mshabarov
Copy link
Contributor

mshabarov commented Jan 16, 2024 •
edited

We currently have the parameter vaadin.frontend.frontend.folder (also see https://vaadin.com/docs/latest/configuration/maven) for setting a relative custom path for frontend folder, but I'm pretty sure that it's broken as in some parts of Flow the frontend folder path is hardcoded. Needs to be checked.

caalador added a commit that referenced this issue Feb 7, 2024
@caalador
feat: Move default frontend to src/main
9befc8d 
Move frontend folder from root
to src/main.

Closes #18436
@caalador caalador mentioned this issue Feb 7, 2024
Closed
caalador added a commit that referenced this issue Feb 7, 2024
@caalador
feat: Move default frontend to src/main
bccf274 
Move frontend folder from root
to src/main.

Closes #18436
caalador added a commit that referenced this issue Feb 26, 2024
@caalador
feat: Move default frontend to src/main
3c63cc3 
Move frontend folder from root
to src/main.

Closes #18436
@caalador caalador self-assigned this Feb 26, 2024
@caalador caalador mentioned this issue Feb 26, 2024
Closed
@manolo manolo changed the title Consider moving /frontend directory under /src/main Move /frontend directory under /src/main by default Mar 5, 2024
mshabarov added a commit to vaadin/docs that referenced this issue Mar 12, 2024
@mshabarov
feat: Change default location of frontend directory
d2e430a 
Related-to vaadin/flow#18436
@mshabarov mshabarov mentioned this issue Mar 12, 2024
Merged
mshabarov added a commit to vaadin/docs that referenced this issue Mar 14, 2024
@mshabarov @russelljtdyer @caalador
feat: Change default location of frontend directory (#3280)
bf577f8 
* feat: Change default location of frontend directory

Related-to vaadin/flow#18436

* change file extensions  to .adoc

* More file extensions changed to .adoc

* First pass at editing only changed text.

* More editing of changed text and surrounding text.

* Apply suggestions from code review

Co-authored-by: caalador <mikael.grankvist@vaadin.com>

* chore: Replace generatedFolder with generatedTsFolder

* chore: Replace generatedFolder with generatedTsFolder

---------

Co-authored-by: Russell J.T. Dyer <6652767+russelljtdyer@users.noreply.github.com>
Co-authored-by: Russell JT Dyer <russelljtdyer@users.noreply.github.com>
Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caalador caalador

Labels
enhancement Released with Vaadin 24.4.0
Projects
Roadmap
Status: June 2024 (24.4)
Vaadin Flow ongoing work (Vaadin 10+)
Status: Done
Milestone
No milestone
4 participants
@caalador @vaadin-bot @tarekoraby @mshabarov