-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log or throw for non-existent feature flags #18672
Comments
Hi, I'd like to try to implement this feature) |
The feature should be added into loadProperties in the FeatureFlags class. One thing to note is that there should be a static flag that even if we get multiple calls to loadProperties we should only log the faulty keys once and not multiple times. |
For contribution guidelines, please see these docs. |
There was no indication if you were using non-existent or unsupported feature flags at startup. This change brings log warnings about existence of such feature flags Fixes #18672
There was no indication if you were using non-existent or unsupported feature flags at startup. This change brings log warnings about existence of such feature flags Fixes #18672 Co-authored-by: Mikhail Schastlivtsev <rodsher111@gmail.com>
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Describe your motivation
When adding a non-existent feature flag to
vaadin-featureflags.properties
, the app starts normally without errors or any indication in the logs that something unexpected happened. This behavior is problematic (a) for people upgrading to newer versions where the feature flag is no longer working, and (b) when typos are made in the feature flag name.Describe the solution you'd like
During startup, an error should be thrown, or a warning should be logged, if a non-supported feature flag is present in
vaadin-featureflags.properties
.The text was updated successfully, but these errors were encountered: