Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment in generated routes.tsx is confusing #18988

Closed
Tracked by #5012
Legioth opened this issue Mar 19, 2024 · 2 comments · Fixed by #19020
Closed
Tracked by #5012

Comment in generated routes.tsx is confusing #18988

Legioth opened this issue Mar 19, 2024 · 2 comments · Fixed by #19020
Labels
awaits another ticket bug Impact: High prerelease version for Vaadin 24.4.0 Released with Vaadin 24.4.0.alpha21 Severity: Minor

Comments

@Legioth
Copy link
Member

Legioth commented Mar 19, 2024

Description of the bug

There's a comment in the generated frontend/generated/routes.tsx file about making your own customizations to the file. The problem is that the user should only make changes to frontend/routes.tsx but not to the file in frontend/generated/.

Expected behavior

The comment should first guide the user to create a copy of the file and only the modify that copy.

Minimal reproducible example

N/A

Versions

  • Vaadin / Flow version: 24.4.0.alpha15
This was referenced Mar 19, 2024
Closed
Open
@mshabarov
Copy link
Contributor

Comments added in #19020.

@mshabarov mshabarov mentioned this issue Mar 26, 2024
Merged
mshabarov added a commit that referenced this issue Apr 9, 2024
@mshabarov
feat: Use a new RouterBuilder API for routes.tsx (#19020)
a07e2ad 
Removes the buildRoutes method and replaces it with a new RouterBuilder API that automatically injects server side routes where needed and adds the auth level.

Related-to vaadin/hilla#2238

Fixes #18988
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha21 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaits another ticket bug Impact: High prerelease version for Vaadin 24.4.0 Released with Vaadin 24.4.0.alpha21 Severity: Minor
Projects
Vaadin Flow ongoing work (Vaadin 10+)
Status: Done
Milestone
No milestone
3 participants
@Legioth @vaadin-bot @mshabarov