[PiT 24.4] a theme loading delay can be observed with hilla-react-gradle starter

[ZheSun88]

Describe the bug

with the Vaadin 24.4.0.alpha24, there is an notable delay on applying the theme when start the hilla-react-gradle starter

Expected-behavior

this is the behavior on alpha23, i think it should be look like this

Reproduction

use the attached app or do the following steps

   git clone https://github.com/vaadin/skeleton-starter-hilla-react-gradle.git
   cd skeleton-starter-hilla-react-gradle
   perl -pi -e 's|\s*(hillaVersion)\s*([=:]).*|${1}${2}24.4.0.alpha24|g' gradle.properties
   # Patching Gradle project
   perl -pi -e 's|dev\.hilla:hilla-bom|com.vaadin:vaadin-bom|' build.gradle
   perl -pi -e 's|dev\.hilla:hilla-(react-)?spring-boot-starter|com.vaadin:vaadin-spring-boot-starter|' build.gradle
   perl -pi -e 's|hillaVersion|vaadinVersion|' build.gradle settings.gradle gradle.properties
   perl -pi -e 's|dev\.hilla|com.vaadin|' build.gradle settings.gradle
   find src/main -name '*.java' -exec perl -pi -e 's/import dev.hilla/import com.vaadin.hilla/g' '{}' ';'
   find frontend '(' -name '*.ts' -o -name '*.tsx' ')' -exec perl -pi -e 's|\@hilla/form|\@vaadin/hilla-lit-form|g' '{}' ';'
   find frontend '(' -name '*.ts' -o -name '*.tsx' ')' -exec perl -pi -e 's|Frontend/generated/dev/hilla|Frontend/generated/com/vaadin/hilla|g' '{}' ';'
   find frontend '(' -name '*.ts' -o -name '*.tsx' ')' -exec perl -pi -e 's|\@hilla/frontend|\@vaadin/hilla-frontend|g' '{}' ';'
   find frontend '(' -name '*.ts' -o -name '*.tsx' ')' -exec perl -pi -e 's|\@hilla/react-form|\@vaadin/hilla-react-form|g' '{}' ';'
   find frontend '(' -name '*.ts' -o -name '*.tsx' ')' -exec perl -pi -e 's|\@hilla/|\@vaadin/|g' '{}' ';'
  mv frontend src/main/frontend

run ./gradlew bootRun and observe the initial load

skeleton-starter-hilla-react-gradle.zip

System Info

tested on both mac and windows, behave the same
version: Vaadin 24.4.0.alpha24

[mshabarov]

This seems to be a regression after #19221.
I tested alpha24 with and without this change and it clearly happens when I have this change.

[mshabarov]

@ZheSun88 is bug reproducible with 24.4.0.alpha25? I tested with hybrid app and couldn't see it.

[mcollovati]

Isn't alpha25 the version with the revert?

[mshabarov]

Yes, it has a revert already. But just wondered, was this issue opened because it was reproduced after revert, or it was re-opened for tracking other branches that have no revert and no second fix yet.

[ZheSun88]

it was re-opened for tracking other branches that have no revert and no second fix yet.

ah.. this one..

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.3.11.

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.4.0.beta2 and is also targeting the upcoming stable 24.4.0 version.

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.