Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename @ClientDelegate to something which tells what it does #2249

Closed
Artur- opened this issue Aug 28, 2017 · 2 comments
Closed

Rename @ClientDelegate to something which tells what it does #2249

Artur- opened this issue Aug 28, 2017 · 2 comments

Comments

@Artur-
Copy link
Member

Artur- commented Aug 28, 2017

The javadoc says
Publishes the annotated method so it can be invoked from the client side using the notation <code>this.$server.method()</code> in template methods

so how about a name that says it is published so it can be invoked from the client side?
Like @PublishToJS or similar?

@pleku
Copy link
Contributor

pleku commented Apr 20, 2018

@ClientSide
@ClientSideMethod
@ClientSideAvailable
@ClientMethod
@PublishToClient
@PublishToClientSide
@CallableFromClient
@AvailableOnClientSide

@pleku
Copy link
Contributor

pleku commented Apr 24, 2018

@ClientCallable won the popular vote and the lottery. Don't forget to update the demos(?), documentation.

@pleku pleku added this to the Before 1.0 RC milestone Apr 24, 2018
@manolo manolo self-assigned this Apr 24, 2018
manolo added a commit that referenced this issue Apr 24, 2018
denis-anisimov pushed a commit that referenced this issue Apr 24, 2018
* Rename ClientDelegate to ClientCallable

Fixes #2249
ZheSun88 added a commit to vaadin/vaadin-iron-list-flow that referenced this issue Apr 25, 2018
ZheSun88 added a commit to vaadin/vaadin-grid-flow that referenced this issue Apr 25, 2018
ZheSun88 added a commit to vaadin/vaadin-iron-list-flow that referenced this issue Apr 25, 2018
* Fixes after flow rename ClientDelegate to ClientCallable

original issue vaadin/flow#2249
ZheSun88 added a commit to vaadin/vaadin-grid-flow that referenced this issue Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants