Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme documentation page doesn't mention creating an app theme #3347

Closed
tmattsso opened this issue Jan 18, 2018 · 2 comments
Closed

Theme documentation page doesn't mention creating an app theme #3347

tmattsso opened this issue Jan 18, 2018 · 2 comments
Milestone

Comments

@tmattsso
Copy link

There is no mention on how to use Lumo and adding your own app styles. Also, the 'creating your own component theme' section is pretty confusing.

@pleku
Copy link
Contributor

pleku commented Jan 18, 2018

There is no mention on how to use Lumo

This is very clearly stated in the docs, care to elaborate ? https://github.com/vaadin/flow/blob/master/flow-documentation/theme/tutorial-built-in-themes.asciidoc

and adding your own app styles.

This was planned as partly with #2428 and #2807, but now it is a bit separate topic (compared to component theming), so closing those since the Valo/Lumo theme usage is there.

Also, the 'creating your own component theme' section is pretty confusing.

Please create another issue for this and open up a bit more than just saying it is pretty confusing, thanks.

@tmattsso
Copy link
Author

Well, it doesn't show an example of a style file or how to name it. It doesn't show how to set basic CSS properties for classnames you've given to your components. It doesn't show how to override a theme setting for example for all buttons. It doesn't discuss if it makes sense to split your style file into multiple files.

Also, this sentence doesn't make any sense to me:

you need to create a theme class that informs flow how to translate the base un-themed component html import to use your themed version.

This sentence doesn't make sense if I don't understand what HtmlImport does, and barely even then

The getBaseUrl should return the part of the htmlImport that can be used to determine if it is an import that could be changed to a theme import. (for Vaadin Elements that is /src/)

Having to override getHeadInlineContents seems like a cumbersome way just to import files.

In all, I have no idea how to create an app theme based on this document. Remember, our customers will not have any clue on how the theme internals work; they just want to make their buttons red.

pleku added a commit to vaadin/flow-and-components-documentation that referenced this issue Mar 26, 2018
Splits existing component theming docs into using ready-made themes and integrating a component theme.
Adds documentation on application theming basics and theming web components.

Fixes vaadin/flow#3347
Fixes vaadin/flow#3042
@pleku pleku added this to the 1.0.0.beta5 milestone Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants