-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme documentation page doesn't mention creating an app theme #3347
Comments
This is very clearly stated in the docs, care to elaborate ? https://github.com/vaadin/flow/blob/master/flow-documentation/theme/tutorial-built-in-themes.asciidoc
This was planned as partly with #2428 and #2807, but now it is a bit separate topic (compared to component theming), so closing those since the Valo/Lumo theme usage is there.
Please create another issue for this and open up a bit more than just saying it is pretty confusing, thanks. |
Well, it doesn't show an example of a style file or how to name it. It doesn't show how to set basic CSS properties for classnames you've given to your components. It doesn't show how to override a theme setting for example for all buttons. It doesn't discuss if it makes sense to split your style file into multiple files. Also, this sentence doesn't make any sense to me:
This sentence doesn't make sense if I don't understand what HtmlImport does, and barely even then
Having to override getHeadInlineContents seems like a cumbersome way just to import files. In all, I have no idea how to create an app theme based on this document. Remember, our customers will not have any clue on how the theme internals work; they just want to make their buttons red. |
Splits existing component theming docs into using ready-made themes and integrating a component theme. Adds documentation on application theming basics and theming web components. Fixes vaadin/flow#3347 Fixes vaadin/flow#3042
There is no mention on how to use Lumo and adding your own app styles. Also, the 'creating your own component theme' section is pretty confusing.
The text was updated successfully, but these errors were encountered: