Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does not Text node implement the HasText interface? #3606

Closed
mvysny opened this issue Feb 26, 2018 · 1 comment
Closed

Why does not Text node implement the HasText interface? #3606

mvysny opened this issue Feb 26, 2018 · 1 comment
Assignees
@Legioth
Labels
enhancement feedback
Milestone
1.0.0.beta9

Comments

@mvysny
Copy link
Member

mvysny commented Feb 26, 2018

Is there some reason why the Text node doesn't implement the HasText interface?
@sblommers
Copy link

sblommers commented Feb 26, 2018 •
edited

Sounds a bit ambiguous to me but technically it should right?

@pleku pleku added this to the Before 1.0 RC milestone Apr 20, 2018
Legioth added a commit that referenced this issue Apr 20, 2018
@Legioth
Make Text implement HasText
6fa92ae 
Fixes #3606
@Legioth Legioth mentioned this issue Apr 20, 2018
Merged
@Legioth Legioth self-assigned this Apr 20, 2018
Legioth added a commit that referenced this issue Apr 20, 2018
@Legioth
Make Text implement HasText
3b5c0f4 
Fixes #3606
gilberto-torrezan pushed a commit that referenced this issue Apr 20, 2018
@Legioth @gilberto-torrezan
Make Text implement HasText (#3948)
571ce22 
* Make Text implement HasText

Fixes #3606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Legioth Legioth

Labels
enhancement feedback
Projects
None yet
Milestone
1.0.0.beta9
Development

No branches or pull requests
5 participants
@mvysny @sblommers @Legioth @pleku @gilberto-torrezan