Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isFromClient to SelectionEvent #3707

Closed
Legioth opened this issue Mar 15, 2018 · 2 comments
Closed

Add isFromClient to SelectionEvent #3707

Legioth opened this issue Mar 15, 2018 · 2 comments
Assignees
Milestone

Comments

@Legioth
Copy link
Member

Legioth commented Mar 15, 2018

When listening to selection changes from e.g. Grid, it's sometimes necessary to know whether the event was triggered programmatically from the server or originated from the client.

One specific use case for this is when HasUrlParameter.setParameter selects the corresponding item in a Grid, and a selection event from Grid causes navigation the the URL corresponding to the selected item.

isFromClient is currently defined in ComponentEvent, so SelectionEvent should either be changed to inherit from that class, or alternatively isFromClient could be extracted to a mixin interface or an even more abstract base class.

@pleku
Copy link
Contributor

pleku commented Mar 15, 2018

SelectionEvent is also missing the source, could be trivial to fix together: #3404

@denis-anisimov
Copy link
Contributor

denis-anisimov commented Mar 16, 2018

Fixed in #3718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants