Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnsupportedBrowserHandler mentions Chrome Frame #3803

Closed
fluorumlabs opened this issue Apr 1, 2018 · 2 comments
Closed

UnsupportedBrowserHandler mentions Chrome Frame #3803

fluorumlabs opened this issue Apr 1, 2018 · 2 comments
Assignees
@denis-anisimov
Labels
bug

Comments

@fluorumlabs
Copy link
Contributor

UnsupportedBrowserHandler.java mentions Chrome Frame. Not only it does not exist anymore, it won't work without <meta http-equiv="X-UA-Compatible" content="chrome=1"> in HTML head.
@pleku
Copy link
Contributor

pleku commented Apr 3, 2018

So the issue is that it mentions something that is not there anymore ?
Or that the unsupported browser page won't work unless the meta tag is added to the response ?

@Legioth
Copy link
Member

Legioth commented Apr 3, 2018

Chrome Frame has been deprecated for many years already and we should remove any references to it.

We removed the X-UA-Compatible attribute that would trigger Chrome Frame a couple of years ago, but apparently we forgot to also update the text that is shown for unsupported browsers.

@pleku pleku added the bug label Apr 18, 2018
@pleku pleku added this to the 1.0 Maintenance milestone Apr 18, 2018
@denis-anisimov denis-anisimov self-assigned this Aug 5, 2018
denis-anisimov pushed a commit that referenced this issue Aug 5, 2018
Update UnsupportedBrowserHandler with removing Chrome Frame
956b12c 
Fixes #3803
@denis-anisimov denis-anisimov mentioned this issue Aug 5, 2018
Merged
ZheSun88 pushed a commit that referenced this issue Aug 6, 2018
@ZheSun88
Update UnsupportedBrowserHandler with removing Chrome Frame (#4484)
013dfea 
* Update UnsupportedBrowserHandler with removing Chrome Frame

Fixes #3803
denis-anisimov pushed a commit that referenced this issue Aug 6, 2018
Update UnsupportedBrowserHandler with removing Chrome Frame (#4484)
5d8dc4c 
* Update UnsupportedBrowserHandler with removing Chrome Frame

Fixes #3803
@denis-anisimov denis-anisimov mentioned this issue Aug 6, 2018
Merged
denis-anisimov pushed a commit that referenced this issue Aug 6, 2018
Update UnsupportedBrowserHandler with removing Chrome Frame (#4484) (#…
4c5bcae 
…4485)


Fixes #3803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denis-anisimov denis-anisimov

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Legioth @pleku @fluorumlabs @denis-anisimov