Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element.removeProperty should fire PropertyChangeEvent if property was removed #3994

Open
Legioth opened this issue Apr 25, 2018 · 3 comments · Fixed by #19196
Open

Element.removeProperty should fire PropertyChangeEvent if property was removed #3994

Legioth opened this issue Apr 25, 2018 · 3 comments · Fixed by #19196
Assignees
@denis-anisimov
Labels
bug element API Impact: Low prerelease version for Vaadin 24.4.0 prerelease version for Vaadin 24.5.0 Released with Vaadin 24.4.0.beta2 Released with Vaadin 24.5.0.alpha1 Severity: Minor
Milestone
1.0.1

Comments

@Legioth
Copy link
Member

Legioth commented Apr 25, 2018

No description provided.

@pleku pleku added this to the 1.0 Maintenance milestone Apr 30, 2018
@denis-anisimov denis-anisimov self-assigned this Apr 30, 2018
denis-anisimov pushed a commit that referenced this issue Apr 30, 2018
Fire an event on removeProperty
a7052ab 
Fixes #3994
@denis-anisimov denis-anisimov mentioned this issue Apr 30, 2018
Merged
denis-anisimov pushed a commit that referenced this issue May 2, 2018
Update overridden method return type.
6335b20 
Fixes #3994
caalador pushed a commit that referenced this issue May 2, 2018
@caalador
Fire an event on removeProperty (#4037)
03ad7df 
Fixes #3994
@gilberto-torrezan gilberto-torrezan modified the milestones: 1.0 Maintenance, 1.0.1 Jul 11, 2018
@akhodyko akhodyko mentioned this issue Apr 17, 2024
Merged
mshabarov pushed a commit that referenced this issue May 2, 2024
@akhodyko
fix: make property change listener trigger on removeProperty (#19196)
63e6dfd 
Removing element property by calling com.vaadin.flow.internal.nodefeature.AbstractPropertyMap#removeProperty does not trigger property change listener because of com.vaadin.flow.internal.nodefeature.ElementPropertyMap#remove method is skipped due to AbstractPropertyMap#removeProperty method calls super:

    public void removeProperty(String name) {
        super.remove(name);
    }

Fixes #3994
@mshabarov
Copy link
Contributor

Reopened, as #19310 has been reverted due to regressions in Flow components.

@mshabarov mshabarov reopened this May 6, 2024
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.beta2 and is also targeting the upcoming stable 24.4.0 version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denis-anisimov denis-anisimov

Labels
bug element API Impact: Low prerelease version for Vaadin 24.4.0 prerelease version for Vaadin 24.5.0 Released with Vaadin 24.4.0.beta2 Released with Vaadin 24.5.0.alpha1 Severity: Minor
Projects
Vaadin Flow bugs & maintenance (Vaadin 10+)
Status: 🔖 Low Priority (P3)
Vaadin Flow ongoing work (Vaadin 10+)
Status: 🅿️Parking lot - under consideration
Milestone
1.0.1
Development

Successfully merging a pull request may close this issue.

fix: make property change listener trigger on removeProperty akhodyko/flow
6 participants
@Legioth @pleku @gilberto-torrezan @denis-anisimov @vaadin-bot @mshabarov