Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal error dialog is broken if a Dialog component is open #4089

Closed
mstahv opened this issue May 8, 2018 · 1 comment
Closed

Internal error dialog is broken if a Dialog component is open #4089

mstahv opened this issue May 8, 2018 · 1 comment
Assignees
@pekam
Labels
bug investigation
Milestone
1.0.0.rc1

Comments

@mstahv
Copy link
Member

mstahv commented May 8, 2018

Steps to reproduce

  1. Add a Dialog to the project
  2. Cause an internal error
  3. Try to click the reload link or hit esc -> nothing happens
@pleku pleku added this to the 1.0 Maintenance milestone May 9, 2018
@pekam pekam self-assigned this May 28, 2018
pekam added a commit that referenced this issue May 28, 2018
@pekam
Ensure that pointerEvents are enabled for error dialog
4f2f4c1 
Because vaadin-overlay sets "pointer-events: none" for the body, an
opened vaadin-dialog makes the internal error dialog unclickable.

Fixes the clicking part of #4089
@pekam pekam mentioned this issue May 28, 2018
Merged
@pekam
Copy link
Contributor

pekam commented May 28, 2018 •
edited

Seems that the click-bug and the esc-bug are caused by completely different things:

pekam added a commit that referenced this issue May 28, 2018
@pekam
Redirect with esc-key after internal error
4fbe3ad 
The message inside the internal error dialog claims that you can
continue either by clicking the dialog or pressing the esc-key. However,
it seems that continuing with the esc-key was never implemented.

Fixes partly #4089
@pekam pekam mentioned this issue May 28, 2018
Merged
pekam added a commit that referenced this issue May 29, 2018
@pekam
Ensure that pointerEvents are enabled for error dialog (#4188)
40abecc 
Because vaadin-overlay sets "pointer-events: none" for the body, an
opened vaadin-dialog makes the internal error dialog unclickable.

Fixes the clicking part of #4089
caalador pushed a commit that referenced this issue May 30, 2018
@pekam @caalador
Redirect with esc-key after internal error (#4190)
9061699 
The message inside the internal error dialog claims that you can
continue either by clicking the dialog or pressing the esc-key. However,
it seems that continuing with the esc-key was never implemented.

Fixes partly #4089

Add tests for the 'internal error' notification

Also add '@after' method to reset the SystemMessages changes made by the session expired test.
pekam added a commit to vaadin/vaadin-dialog-flow that referenced this issue Jun 4, 2018
@pekam
Test that 'Internal error' dialog can be closed when Dialog is open
57be45f 
Adds tests for this issue which was fixed in Flow:
vaadin/flow#4089
@ZheSun88 ZheSun88 modified the milestones: 1.0 Maintenance, 1.0.0.rc2, 1.0.0.rc1 Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pekam pekam

Labels
bug investigation
Projects
None yet
Milestone
1.0.0.rc1
Development

No branches or pull requests
5 participants
@mstahv @pleku @caalador @pekam @ZheSun88