Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Div implements ClickNotifier with raw type #4500

Closed
stefanuebe opened this issue Aug 9, 2018 · 2 comments
Closed

Div implements ClickNotifier with raw type #4500

stefanuebe opened this issue Aug 9, 2018 · 2 comments
Assignees
Milestone

Comments

@stefanuebe
Copy link
Contributor

It's currently

public class Div extends HtmlContainer implements ClickNotifier {

but should be

public class Div extends HtmlContainer implements ClickNotifier<Div> {
@stefanuebe stefanuebe changed the title Div is implementing ClickNotifier with raw type Div implements ClickNotifier with raw type Aug 9, 2018
@denis-anisimov denis-anisimov self-assigned this Aug 9, 2018
@ZheSun88
Copy link
Contributor

ZheSun88 commented Aug 9, 2018

in this case, should also check other HTML components:
Span is using the same https://github.com/vaadin/flow/blob/master/flow-html-components/src/main/java/com/vaadin/flow/component/html/Span.java#L30

Article: https://github.com/vaadin/flow/blob/master/flow-html-components/src/main/java/com/vaadin/flow/component/html/Article.java#L30

i didn't go through all of them... but need to check maybe all the others

@denis-anisimov
Copy link
Contributor

Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants