Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double elemental.json dependencies on the classpath #4569

Closed
Legioth opened this issue Aug 30, 2018 · 1 comment
Closed

Double elemental.json dependencies on the classpath #4569

Legioth opened this issue Aug 30, 2018 · 1 comment
Labels
Milestone

Comments

@Legioth
Copy link
Member

Legioth commented Aug 30, 2018

When starting an application using 1.1-SNAPSHOT, warnings are logged for various elemental.json classes being found from two different locations on the classpath: com/vaadin/external/gwt/gwt-elemental/2.8.2.vaadin1/gwt-elemental-2.8.2.vaadin1.jar and com/google/gwt/gwt-elemental/2.8.2/gwt-elemental-2.8.2.jar. This happens because our own 2.8.2.vaadin1 version has the original as a regular dependency in its pom.xml.

@ZheSun88 ZheSun88 added the bug label Sep 3, 2018
@pleku pleku added this to the 1.1.0 milestone Sep 5, 2018
pekam added a commit that referenced this issue Sep 11, 2018
pekam added a commit that referenced this issue Sep 12, 2018
* Exclude duplicate gwt-elemental dependency

Fixes #4569

* Remove the other exclude which is now redundant

it was coming transitively from gwt-elemental

* Revert changes in the test caused by the dependency

Seems that the exclusion for validation API didn't work in the first
place, which is why these changes to the test were made the same time
the dependency was updated: #4416

Now the validation API is correctly excluded so the error messages are
back to original.
@pekam
Copy link
Contributor

pekam commented Sep 12, 2018

Symptoms fixed by excluding the dependency.
Follow-up ticket for fixing the root-cause: #4598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants