Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme variants are not generated in deterministic order #4677

Closed
pekam opened this issue Oct 8, 2018 · 0 comments
Closed

Theme variants are not generated in deterministic order #4677

pekam opened this issue Oct 8, 2018 · 0 comments
Assignees
@denis-anisimov
Labels
bug generator
Milestone
1.2.0.beta1

Comments

@pekam
Copy link
Contributor

pekam commented Oct 8, 2018

In 5523fb9, the web component API analyzer randomly recognized material theme variants before lumo, changing the order in which GridVariant.values() returns the variants.
@denis-anisimov denis-anisimov self-assigned this Oct 22, 2018
denis-anisimov pushed a commit that referenced this issue Oct 23, 2018
Produce deterministic output for theme variants enum
0655ef5 
Fixes #4677
denis-anisimov pushed a commit that referenced this issue Oct 23, 2018
Sort variants by the theme name to produce deterministic result
0af1e73 
Fixes #4677
@denis-anisimov denis-anisimov mentioned this issue Oct 23, 2018
Merged
caalador pushed a commit that referenced this issue Oct 23, 2018
@caalador
Sort variants by the theme name to produce deterministic (#4720)
aea9958 
Produce deterministic output for theme variants enum and
sort variants by the theme name to produce deterministic result

Fixes #4677
@SomeoneToIgnore SomeoneToIgnore added this to the 1.2.0.beta1 milestone Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denis-anisimov denis-anisimov

Labels
bug generator
Projects
None yet
Milestone
1.2.0.beta1
Development

No branches or pull requests
3 participants
@SomeoneToIgnore @denis-anisimov @pekam