Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic DnD is broken in Firefox starting drag inside shadow dom #5606

Closed
pleku opened this issue May 3, 2019 · 2 comments
Closed

Generic DnD is broken in Firefox starting drag inside shadow dom #5606

pleku opened this issue May 3, 2019 · 2 comments

Comments

@pleku
Copy link
Contributor

pleku commented May 3, 2019

FF issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1521471

Plan: investigate a workaround

If plan fails and we can't get it to work, then we will revert the generic drag and drop feature #3978 from Flow 2.0. and include it to a later minor when the drag and drop is also working in Chrome.

@pleku pleku self-assigned this May 3, 2019
pleku added a commit that referenced this issue May 7, 2019
Related to #5606, due to drag and drop issues on Firefox for shadow dom.

Mostly only moves the files around to a new module.
For now the connector resource is added always to the page when the static methods are used for the first time.
pleku added a commit that referenced this issue May 7, 2019
Related to #5606, due to drag and drop issues on Firefox for shadow dom.

Mostly only moves the files around to a new module.
For now the connector resource is added always to the page when the static methods are used for the first time.
pleku added a commit that referenced this issue May 7, 2019
Related to #5606, due to drag and drop issues on Firefox for shadow dom.

Mostly only moves the files around to a new module.
For now the connector resource is added always to the page when the static methods are used for the first time.
pleku added a commit that referenced this issue May 7, 2019
Related to #5606, due to drag and drop issues on Firefox for shadow dom.

Mostly only moves the files around to a new module.
For now the connector resource is added always to the page when the static methods are used for the first time.
pleku added a commit that referenced this issue May 7, 2019
Related to #5606, due to drag and drop issues on Firefox for shadow dom.

Mostly only moves the files around to a new module.
For now the connector resource is added always to the page when the static methods are used for the first time.
pleku added a commit that referenced this issue May 7, 2019
Related to #5606, due to drag and drop issues on Firefox for shadow dom.

Mostly only moves the files around to a new module.
For now the connector resource is added always to the page when the static methods are used for the first time.
pleku added a commit that referenced this issue May 8, 2019
Related to #5606, due to drag and drop issues on Firefox for shadow dom.

Mostly only moves the files around to a new module.
For now the connector resource is added always to the page when the static methods are used for the first time.
@pleku
Copy link
Contributor Author

pleku commented May 8, 2019

The workarounds were not helping enough to be considered to add to Flow.

Thus generic DnD feature has been moved to its own module flow-dnd that will be released with Flow 2.0 but it will not be added to the platform in 14.0.

Once the ^ mentioned FF issue has been fixed, we can then included the flow-dnd module to the platform in a new minor release of 14. So if you don't need Firefox support for your Flow app using DnD, you can take the flow-dnd module and add it to your Vaadin 14 project.

The only workaround for FF that worked was to force the shadow dom polyfill to be used instead of native support with implementing PageConfigurator in the main layout and:

    public void configurePage(InitialPageSettings settings) {
        if (settings.getBrowser().isFirefox()) {
            settings.addInlineWithContents(InitialPageSettings.Position.PREPEND,
                    "  if (window.customElements) window.customElements.forcePolyfill = true;"
                            + "  ShadyDOM = { force: true };",
                    InitialPageSettings.WrapMode.JAVASCRIPT);
        }
    }

It should be noted that this can reduce the performance of the application severely.

Keeping this issue open until the FF bug has been fixed.

pleku added a commit that referenced this issue May 8, 2019
Related to #5606, due to drag and drop issues on Firefox for shadow dom.

Mostly only moves the files around to a new module.
For now the connector resource is added always to the page when the static methods are used for the first time.
@joheriks
Copy link
Contributor

To test with latest Firefox, which contains the fix.

@pleku pleku moved this from Product backlog to In progress in OLD Vaadin Flow ongoing work (Vaadin 10+) Aug 21, 2019
@pleku pleku moved this from In progress to External Reviews in OLD Vaadin Flow ongoing work (Vaadin 10+) Aug 29, 2019
@pleku pleku moved this from External Reviews to In progress in OLD Vaadin Flow ongoing work (Vaadin 10+) Aug 29, 2019
@pleku pleku closed this as completed Oct 17, 2019
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from In progress to Done - pending release Oct 17, 2019
@pleku pleku moved this from Done - pending release to Released in OLD Vaadin Flow ongoing work (Vaadin 10+) Oct 17, 2019
@pleku pleku added this to the 2.1.0.beta1 milestone Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants