Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that pnpm installed locally (not globally) works in the same way as globally installed #7019

Closed
denis-anisimov opened this issue Nov 25, 2019 · 1 comment · Fixed by #7051

Comments

@denis-anisimov
Copy link
Contributor

Initial part of #6966:

  • we should not require (preferably) to have pnpm installed.
  • if pnpm is installed globally we should use it.
  • if there is no installed pnpm globally then we should install it locally (in node_modules folder): is it possible at all ?
    -check that locally installed pnpm works in the same way as globally installed: it uses global cache. Otherwise there is no sense to install it locally since different projects will have different scripts (with different locations).
  • If it's possible to use local pnpm : create a method in the FrontendUtils class to get executable commend for pnpm ( see described algorithm above).
@denis-anisimov
Copy link
Contributor Author

Locally installed npm seems is working in the same way as globally installed.
I don't see a difference.
If it's installed locally then the path to the JS is : node_modules/pnpm/bin/pnpm.js. (Inside a project dir).

denis-anisimov pushed a commit that referenced this issue Nov 28, 2019
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from In progress to Done - pending release Nov 28, 2019
denis-anisimov pushed a commit that referenced this issue Nov 28, 2019
@joheriks joheriks added this to the 2.2.0.alpha6 milestone Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Development

Successfully merging a pull request may close this issue.

2 participants