Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the dependency to vaadin-spring from tests #7030

Closed
vlukashov opened this issue Nov 26, 2019 · 0 comments
Closed

remove the dependency to vaadin-spring from tests #7030

vlukashov opened this issue Nov 26, 2019 · 0 comments
Assignees
Labels
hilla Issues related to Hilla
Milestone

Comments

@vlukashov
Copy link

When building the flow-server package I do not want any of the tests to depend on the vaadin-spring package, so that I can build and release flow-server without having to solve circular dependency issues.

Currently, the flow-ccdm-connect integration test for Flow has a dependency to vaadin-spring. vaadin-spring in its turn has a compile-time dependency to flow-server. That makes maintenance and release process difficult (and in many ways broken).

details: https://vaadin.slack.com/archives/CDNTYMS9H/p1574757699131200

DoD:

  • the flow-ccdm-connect integration test is moved from the flow repo into the vaadin-spring repo and there is no circular dependency between flow and vaadin-spring.
@vlukashov vlukashov added the hilla Issues related to Hilla label Nov 26, 2019
@vlukashov vlukashov added this to the CCDM MVP milestone Nov 26, 2019
vlukashov pushed a commit that referenced this issue Nov 26, 2019
There is a separate task to remove the dependency later: #7030
@manolo manolo self-assigned this Dec 3, 2019
@manolo manolo closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla
Projects
None yet
Development

No branches or pull requests

2 participants