New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not run BabelMultitargetPlugin in dev mode by default to speedup initial webpack build #7434
Comments
In practice, we need to push the plugin to be run only when a given parameter is set for the webpack plugin. It is not worthwhile to generate another webpack config based on this because that is part of the Currently reported ES6 support https://caniuse.com/#feat=es6 This feature is unnecessary for Flow 3.0 because it doesn't have the plugin anymore, so it should be targeted tot 2.2 branch. |
To see an example on how to pass a parameter to webpack, there is the watchdog server port passed from Java to the webpack configuration. |
Does the parameter need to come from Java instead of user’s webpack.config.js? |
IMO it should be possible to configure it in Java when you decide to run your application server like Do you @Artur- see additional benefit in having it explicitly in |
On a fast laptop:
Thus for development mode, we should make BabelMultiTargetPlugin to be only run on request when the developer wants to test with older browsers.
For production mode, it should stay as always run by default, but probably could make sense to (in a separate step) make that also configurable (separately to development build).
Acceptance Criteria
BabelMultiTargetPlugin
triggered for the webpack build only if the parameterdevmode.transpile
(or better name) is set totrue
build-frontend
goal-> this needs to be done for any browser that will now start failing in devmode without transpilation
The text was updated successfully, but these errors were encountered: