Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to tsconfig.json get reverted #7532

Closed
tomivirkki opened this issue Feb 10, 2020 · 1 comment · Fixed by #7621
Closed

Changes to tsconfig.json get reverted #7532

tomivirkki opened this issue Feb 10, 2020 · 1 comment · Fixed by #7621
Labels
bug hilla Issues related to Hilla

Comments

@tomivirkki
Copy link
Member

https://vaadin.com/docs/v15/flow/typescript/intro-to-typescript-in-v15.html#configuring-typescript-compiler documents that vaadin-maven-plugin generates one in case there is no tsconfig.json in the project root but it seems that any changes to an existing tsconfig.json file also get reverted even when the file exists.

Use-case: I need to add "resolveJsonModule": true to support importing .json files to my view, but it gets removed as soon as I start the server with mvn spring-boot:run
@vlukashov vlukashov added the hilla Issues related to Hilla label Feb 10, 2020
manolo added a commit that referenced this issue Feb 18, 2020
@manolo
CCDM: do not override tsconfig if it exists but there is no custom in…
edaebdf 
…dex.ts file

Fixes #7532
@manolo manolo mentioned this issue Feb 18, 2020
Merged
manolo added a commit that referenced this issue Feb 18, 2020
@manolo
CCDM: do not override tsconfig if it exists but there is no custom in…
d748f07 
…dex.ts file

Fixes #7532
@manolo
Copy link
Member

manolo commented Feb 18, 2020

@tomivirkki I guess you had a customized tsconfig.json in your project but not a customized frontend/index.ts. The code was assuming that if flow generates a target/index.ts it always overrides the tsconfig.json. Sent a PR fixing this case

manolo added a commit that referenced this issue Feb 18, 2020
@manolo
CCDM: do not override tsconfig if it exists but there is no custom in…
79dcfc2 
…dex.ts file

Fixes #7532
manolo added a commit that referenced this issue Feb 19, 2020
@manolo
CCDM: do not override tsconfig if it exists but there is no custom in…
e4d19f3 
…dex.ts file

Fixes #7532
manolo added a commit that referenced this issue Feb 19, 2020
@manolo
CCDM: do not override tsconfig if it exists but there is no custom in…
d208584 
…dex.ts file

Fixes #7532
haijian-vaadin pushed a commit that referenced this issue Feb 20, 2020
@manolo
CCDM: do not override tsconfig when index.ts is generated (#7621)
c5e9c95 
* CCDM: do not override tsconfig if it exists but there is no custom index.ts file

Fixes #7532

* simplify tsconfig generation condition

* fix tests
haijian-vaadin pushed a commit that referenced this issue Feb 24, 2020
@manolo @haijian-vaadin
CCDM: do not override tsconfig when index.ts is generated (#7621)
8d69a47 
* CCDM: do not override tsconfig if it exists but there is no custom index.ts file

Fixes #7532

* simplify tsconfig generation condition

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug hilla Issues related to Hilla
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CCDM: do not override tsconfig when there is an existing one vaadin/flow
4 participants
@manolo @tomivirkki @vlukashov @haijian-vaadin