Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCDM: in MPR projects client routing fails when navigating flow->vaadin #7540

Closed
manolo opened this issue Feb 11, 2020 · 0 comments · Fixed by #7673
Closed

CCDM: in MPR projects client routing fails when navigating flow->vaadin #7540

manolo opened this issue Feb 11, 2020 · 0 comments · Fixed by #7673
Assignees
@manolo
Labels
bug hilla Issues related to Hilla Impact: Low Severity: Major

Comments

@manolo
Copy link
Member

manolo commented Feb 11, 2020 •
edited

Navigation in vaadin7/8 use the hash fragment which is not correctly handled in vaadin15 using client side routing.

To reproduce it run mvn jetty:run in multiplatform-runtime-internal/mpr-tests/navigation project (you need to set vaadin.useDeprecatedV14Bootstrapping in pom.xml).
In this project tests navigatorInitializesOnlyOnce and navigatorShowsFirstViewAndCanNavigate fail when running mvn validate .

  • In the next screenshots running client-side bootstraping you can see the problem

client-1
client-2

  • The same screenshots running server-side bootstraping do not have the problem

server-1
server-2
@manolo manolo added bug hilla Issues related to Hilla labels Feb 11, 2020
@manolo manolo self-assigned this Feb 20, 2020
@manolo manolo mentioned this issue Feb 25, 2020
Merged
manolo added a commit that referenced this issue Feb 26, 2020
@manolo
prevent that MPR routes modify the hash fragment
e2e57cc 
- Routing based on hash fragment was executing code in
  browser that causes firing client side routing breaking 
  the UI.
- This PR introspects the V7 UIDL in order to replace 
  'window.location.hash' assignation with new API
  'window.history.pushState'.

Fixes #7540
@manolo manolo reopened this Feb 26, 2020
manolo added a commit that referenced this issue Mar 2, 2020
@manolo
prevent that MPR routes modify the hash fragment
796a950 
- Routing based on hash fragment was executing code in
  browser that causes firing client side routing breaking 
  the UI.
- This PR introspects the V7 UIDL in order to replace 
  'window.location.hash' assignation with new API
  'window.history.pushState'.

Fixes #7540
manolo added a commit that referenced this issue Mar 2, 2020
@manolo
7673, 7692, 7693 3.0 cherry pick (#7732)
9c98cf1 
* prevent that MPR routes modify the hash fragment

Fixes #7540

- Routing based on hash fragment was executing code in
  browser that causes firing client side routing breaking 
  the UI.
- This PR introspects the V7 UIDL in order to replace 
  'window.location.hash' assignation with new API
  'window.history.pushState'.
@manolo manolo closed this as completed Mar 6, 2020
@mshabarov mshabarov mentioned this issue Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manolo manolo

Labels
bug hilla Issues related to Hilla Impact: Low Severity: Major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prevent that MPR routes modify the hash fragment vaadin/flow
2 participants
@manolo @haijian-vaadin