Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCDM: history actions do not work as in v14 #7572

Closed
manolo opened this issue Feb 13, 2020 · 8 comments
Closed

CCDM: history actions do not work as in v14 #7572

manolo opened this issue Feb 13, 2020 · 8 comments

Comments

@manolo
Copy link
Member

manolo commented Feb 13, 2020

Enable client-side mode in flow-tests/test-root-context and run either HistoryIT BackButtonServerRoundTripIT, they will fail

mvn verify -Dvaadin.useDeprecatedV14Bootstrapping=false -Dit.test=HistoryIT,BackButtonServerRoundTripIT
@ajgassner
Copy link
Contributor

ajgassner commented Apr 14, 2020

Currently we are unable to use Vaadin 15 in our project. Everything works fine except the history API and router links. We aren't using client side views yet.

E.g. UI.getCurrent().page.history.back() or RouterLink("test", SomeView::class.java) are unreliable, they change the URL but no content changes on the page sometimes. Same behavior tested directly in the browser's console with history.back().

@haijian-vaadin I suggest to to raise the severity of this issue, it's a real problem. I think it's somehow caused by vaadin-router on the client side.

@haijian-vaadin
Copy link
Contributor

Hi @ajgassner thanks a lot for the feedback. It indeed sounds more severe than we originally estimated. Do you have a project that we can use to reproduce the problem?

@ajgassner
Copy link
Contributor

Mhm i just tried to reproduce the issue with a small sample application. With this minimal example it works as expected. I really don't know what's causing the problem in our larger production application unfortunately. There's also nothing special or custom.

@haijian-vaadin
Copy link
Contributor

Hi @ajgassner, do you happen to use ui.navigate()? wonder if #8071 is related or not.

@ajgassner
Copy link
Contributor

ajgassner commented Apr 16, 2020

Hi @haijian-vaadin!

Yes that‘s the case. E.g. ui.page.history.back() is also affected.
Here is a reproduction demo: demo.zip

@haijian-vaadin
Copy link
Contributor

Thanks for the demo @ajgassner, wow, you are using Kotlin, cool!

@haijian-vaadin
Copy link
Contributor

@ajgassner this issue should now be fixed in the @vaadin/router 1.7.2.
You can try to delete the node_modules folder and the package-lock.json in your project, then it should be able to get @vaadin/router 1.7.2. You can give it a try and let us know if it works for you.

@haijian-vaadin
Copy link
Contributor

HistoryIT is still failing, but keep this ticket closed and open vaadin/hilla#316 for tracking this particular issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants