Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCDM: HistoryStateChangeHandler is not called when history state changes with client-side routing #316

Open
haijian-vaadin opened this issue Apr 30, 2020 · 2 comments
Labels
hilla Issues related to Hilla

Comments

@haijian-vaadin
Copy link
Contributor

haijian-vaadin commented Apr 30, 2020

With Router 1.7.2

HistoryIT is currently ignored due to this issue.

When state changes, vaadin-router calls the callbacks as registered in Flow.ts

this.container.onBeforeEnter = (ctx, cmd) => this.flowNavigate(ctx, cmd);
this.container.onBeforeLeave = (ctx, cmd) => this.flowLeave(ctx, cmd);

But HistoryStateChangeHandler is never called.

@haijian-vaadin
Copy link
Contributor Author

Add this as a known limitation in the migration guide.

@denis-anisimov
Copy link

HistoryIT is disabled because of this issue: vaadin/flow#10471

@vaadin-bot vaadin-bot transferred this issue from vaadin/flow Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla
Projects
None yet
Development

No branches or pull requests

2 participants