Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions should not break a UI #801

Closed
denis-anisimov opened this issue May 18, 2016 · 3 comments
Closed

Exceptions should not break a UI #801

denis-anisimov opened this issue May 18, 2016 · 3 comments

Comments

@denis-anisimov
Copy link
Contributor

If exception happens in some event handler (f.e. as a reaction on some client-side event) then UI becomes broken because of internal error.

It's possible to install ErrorHandler via VaadinSession.setErrorHandler and be notified about exceptions but it's not possible to change UI since it becomes broken when an exception is thrown.

UI should remain functional.

@mstahv
Copy link
Member

mstahv commented May 3, 2018

I find this "new behaviour" really nasty for both application developers and end users.

Even if the framework does nothing by default and just kills the UI, we should definitely have a hook for developers to catch "component errors" and let them handle and decide how that app behaves in such situations.

@samie
Copy link
Member

samie commented Aug 15, 2018

For similar problematic error handling situation see also #4377

@CookedApps
Copy link

CookedApps commented Dec 18, 2018

The UI still freezes in Vaadin 12.0.3 if an exception is thrown inside a ValueChangeListener. Example:

textField.addValueChangeListener(e -> {
    throw new RuntimeException();
});

I tested this with Flow version 1.2.3 and 1.3.0.alpha1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants