Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Time" in "Started webpack-dev-server." log message is confusing #8967

Closed
mvysny opened this issue Sep 8, 2020 · 1 comment
Closed

Comments

@mvysny
Copy link
Member

mvysny commented Sep 8, 2020

It's not clear as to what does this log message refer to: Started webpack-dev-server. Time: 3897781ms. It definitely can't be a duration of the webpack dev server startup since 3897781ms is something like one hour, and the dev server started much quicker as can be seen in the log:

08-Sep-2020 10:21:51.739 INFO [main] org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler ["http-nio-8080"]
08-Sep-2020 10:21:51.755 INFO [main] org.apache.catalina.startup.Catalina.start Server startup in [66] milliseconds
Connected to server
[2020-09-08 10:21:52,166] Artifact skeleton-starter-flow:war exploded: Artifact is being deployed, please wait...
08-Sep-2020 10:21:53.632 INFO [RMI TCP Connection(2)-127.0.0.1] org.apache.jasper.servlet.TldScanner.scanJars At least one JAR was scanned for TLDs yet contained no TLDs. Enable debug logging for this logger for a complete list of JARs that were scanned but no TLDs were found in them. Skipping unneeded JARs during scanning can improve startup time and JSP compilation time.
[RMI TCP Connection(2)-127.0.0.1] INFO com.vaadin.flow.server.startup.DevModeInitializer - Starting dev-mode updaters in /home/mavi/temp/skeleton-starter-flow folder.
[RMI TCP Connection(2)-127.0.0.1] INFO dev-updater - Visited 74 classes. Took 46 ms.
[RMI TCP Connection(2)-127.0.0.1] INFO dev-updater - Skipping `npm install` because the frontend packages are already installed in the folder '/home/mavi/temp/skeleton-starter-flow/node_modules' and the hash in the file '/home/mavi/temp/skeleton-starter-flow/node_modules/.vaadin/vaadin.json' is the same as in 'package.json'
[RMI TCP Connection(2)-127.0.0.1] INFO dev-updater - Copying frontend resources from jar files ...
[RMI TCP Connection(2)-127.0.0.1] INFO dev-updater - Visited 13 resources. Took 38 ms.
[RMI TCP Connection(2)-127.0.0.1] INFO dev-updater - Updated /home/mavi/temp/skeleton-starter-flow/target/frontend/generated-flow-imports.js

------------------ Starting Frontend compilation. ------------------
[RMI TCP Connection(2)-127.0.0.1] INFO dev-webpack - Running webpack to compile frontend resources. This may take a moment, please stand by...
[RMI TCP Connection(2)-127.0.0.1] INFO dev-webpack - Started webpack-dev-server. Time: 3897781ms
08-Sep-2020 10:21:59.114 INFO [RMI TCP Connection(2)-127.0.0.1] org.apache.catalina.core.ApplicationContext.log Initializing AtmosphereFramework
[RMI TCP Connection(2)-127.0.0.1] INFO com.vaadin.flow.server.startup.ServletDeployer - Automatically deploying Vaadin servlet with name com.vaadin.flow.server.startup.ServletDeployer to /*
Vaadin application has been deployed and started to the context path "/".
[2020-09-08 10:21:59,305] Artifact skeleton-starter-flow:war exploded: Artifact is deployed successfully
[2020-09-08 10:21:59,305] Artifact skeleton-starter-flow:war exploded: Deploy took 7,139 milliseconds
[http-nio-8080-exec-1] INFO com.vaadin.flow.server.DefaultDeploymentConfiguration - 
Vaadin is running in DEBUG MODE.
When deploying application for production, remember to disable debug features. See more from https://vaadin.com/docs/

Minimal reproducible example

  1. git clone https://github.com/vaadin/skeleton-starter-flow
  2. Run it in Intellij+Tomcat

Expected behavior

If the value denotes a duration then the log message should read

Started webpack-dev-server in 3,897ms

Also it would be good if the number would be formatted somehow, since 3897ms is not easy to parse by humans :)

Actual behavior

Flow logs some crazy number.

Versions:

- Vaadin / Flow version: 14.3.4
- Java version: 11
- OS version: Ubuntu 20.04
- Application Server (if applicable): Tomcat 9.0.31
- IDE (if applicable): Intellij
@pleku
Copy link
Contributor

pleku commented Sep 8, 2020

This has been fixed by #8943 and released already in 2.3.5

@pleku pleku closed this as completed Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants