Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log time units #8943

Merged
merged 1 commit into from Sep 4, 2020
Merged

Fix log time units #8943

merged 1 commit into from Sep 4, 2020

Conversation

joheriks
Copy link
Contributor

@joheriks joheriks commented Sep 4, 2020

The unit used when recording start (milliseconds) is not the same as the unit used when recording end (nanoseconds), yielding erroneous timing reports in the log. Record start also in nanoseconds.

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 4 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR DevModeHandler.java#L477: Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed. rule
  2. MAJOR DevModeHandler.java#L482: Invoke method(s) only conditionally. rule
  3. MAJOR DevModeHandler.java#L484: Invoke method(s) only conditionally. rule
  4. MAJOR DevModeHandler.java#L486: Invoke method(s) only conditionally. rule

@joheriks joheriks merged commit 9c860d2 into 2.3 Sep 4, 2020
@joheriks joheriks deleted the joheriks/fix-log-time-units branch September 4, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants