Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid access to arbitrary resource via parent #10356

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

denis-anisimov
Copy link
Contributor

No description provided.

@denis-anisimov denis-anisimov added this to Iteration Reviews in OLD Vaadin Flow ongoing work (Vaadin 10+) via automation Mar 22, 2021
@mshabarov mshabarov enabled auto-merge (squash) March 22, 2021 08:09
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 7 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR HandlerHelper.java#L204: Define and throw a dedicated exception instead of using a generic one. rule
  2. MAJOR VaadinBundleTracker.java#L156: Replace the synchronized class "Hashtable" by an unsynchronized one such as "HashMap". rule
  3. MAJOR VaadinBundleTracker.java#L177: Replace the synchronized class "Hashtable" by an unsynchronized one such as "HashMap". rule
  4. MAJOR VaadinBundleTracker.java#L281: Reduce the total number of break and continue statements in this loop to use at most one. rule
  5. MINOR VaadinBundleTracker.java#L103: Add a "try/catch" block for "openStream". rule
  6. MINOR VaadinBundleTracker.java#L104: Add a "try/catch" block for "copy". rule
  7. MINOR VaadinBundleTracker.java#L104: Add a "try/catch" block for "getOutputStream". rule

@mshabarov mshabarov merged commit c454b70 into 2.6 Mar 22, 2021
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Iteration Reviews to Done - pending release Mar 22, 2021
@mshabarov mshabarov deleted the protect-osgi-resoruces branch March 22, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Development

Successfully merging this pull request may close these issues.

None yet

3 participants