Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow spaces between html function call and back tick #10523

Merged
merged 2 commits into from Mar 31, 2021
Merged

fix: allow spaces between html function call and back tick #10523

merged 2 commits into from Mar 31, 2021

Conversation

denis-anisimov
Copy link
Contributor

fixes #8881

mshabarov
mshabarov previously approved these changes Mar 31, 2021
View reviewed changes
@mshabarov
Copy link
Contributor

@denis-anisimov you added cherry-picked-X.X, should it be target/X.X instead? Other branches need this change also.

@mshabarov mshabarov enabled auto-merge (squash) March 31, 2021 13:10
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 3 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR BundleParser.java#L211: Reduce the total number of break and continue statements in this loop to use at most one. rule
  2. MINOR BundleParser.java#L218: Introduce a new variable instead of reusing the parameter "templateDocument". rule
  3. INFO BundleParser.java#L56: Do not forget to remove this deprecated code someday. rule

@mshabarov mshabarov merged commit ee7aa70 into master Mar 31, 2021
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Iteration Reviews to Done - pending release Mar 31, 2021
@mshabarov mshabarov deleted the 8881-allow-spaces-before-html branch March 31, 2021 13:14
vaadin-bot pushed a commit that referenced this pull request Mar 31, 2021
@vaadin-bot
fix: allow spaces between html function call and back tick (#10523)
24db405 
fixes #8881
vaadin-bot pushed a commit that referenced this pull request Mar 31, 2021
@vaadin-bot
fix: allow spaces between html function call and back tick (#10523)
9704593 
fixes #8881
vaadin-bot pushed a commit that referenced this pull request Mar 31, 2021
@vaadin-bot
fix: allow spaces between html function call and back tick (#10523)
3a157f8 
fixes #8881
vaadin-bot pushed a commit that referenced this pull request Mar 31, 2021
@vaadin-bot
fix: allow spaces between html function call and back tick (#10523)
76b1543 
fixes #8881
vaadin-bot pushed a commit that referenced this pull request Mar 31, 2021
@vaadin-bot
fix: allow spaces between html function call and back tick (#10523)
edfb71c 
fixes #8881
vaadin-bot pushed a commit that referenced this pull request Mar 31, 2021
@vaadin-bot
fix: allow spaces between html function call and back tick (#10523)
ce71f80 
fixes #8881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshabarov mshabarov mshabarov approved these changes

Assignees
No one assigned
Labels
prerelease version for platform 14.6.0 prerelease version for platform 20.0.0 Released with Platform 14.6.0.beta1 Released with Platform 19.0.4 Released with Platform 20.0.0.alpha6 +0.0.1
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BundleParser prints 'no template data' when the html call is followed by a space
3 participants
@denis-anisimov @mshabarov @vaadin-bot