Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Extract theme name from proper folder and skip generated files #10622

Merged
merged 1 commit into from Apr 12, 2021
Merged

fix: Extract theme name from proper folder and skip generated files #10622

merged 1 commit into from Apr 12, 2021

Conversation

mshabarov
Copy link
Contributor

@mshabarov mshabarov commented Apr 12, 2021 •
edited

Extracts the custom theme name from frontend generated folder and skips theme handling when the theme generated file is being created/updated.

Related-to #10451, #10544

IT test to cover component styles live reload is being worked in a separate PR #10584, it is flaky still.
IT test to cover themes switch is under work still.

@mshabarov
fix: Extract theme name from proper folder and skip generated files
ed4de58 
Extracts the custom theme name from frontend generated folder and skips theme handling when the theme generated file is being created/updated.

Related-to #10451, #10544
@mshabarov mshabarov added this to Iteration Reviews in OLD Vaadin Flow ongoing work (Vaadin 10+) via automation Apr 12, 2021
@mshabarov mshabarov requested a review from pleku April 12, 2021 12:22
pleku
pleku approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@pleku pleku left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the comment in the PR description that tests are being worked in another PR so it doesn't look so bad later on :)

@mshabarov
Copy link
Contributor Author

Maybe add the comment in the PR description that tests are being worked in another PR so it doesn't look so bad later on :)

Done :)

@mshabarov mshabarov merged commit 2b180c3 into master Apr 12, 2021
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Iteration Reviews to Done - pending release Apr 12, 2021
@mshabarov mshabarov deleted the fix-theme-switch branch April 12, 2021 14:38
ZheSun88 pushed a commit that referenced this pull request Apr 14, 2021
@mshabarov @ZheSun88
fix: Extract theme name from proper folder and skip generated files (#…
84a1df8 
…10622)

Extracts the custom theme name from frontend generated folder and skips theme handling when the theme generated file is being created/updated.

Related-to #10451, #10544
mshabarov added a commit that referenced this pull request Apr 15, 2021
@vaadin-bot @mshabarov
fix: Extract theme name from proper folder and skip generated files (#…
6dff89f 
…10622) (#10647)

Extracts the custom theme name from frontend generated folder and skips theme handling when the theme generated file is being created/updated.

Related-to #10451, #10544

Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleku pleku pleku approved these changes

Assignees
No one assigned
Labels
+0.0.1
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mshabarov @pleku @vaadin-bot