fix: Check assets for url handling #10746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a resource is not found in themes folder check also any assets that are copied for the theme. fixes #10426
caalador
added this to Iteration Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
via automation
mshabarov
reviewed
Apr 21, 2021
mshabarov
reviewed
Apr 21, 2021
mshabarov
reviewed
Apr 21, 2021
flow-tests/test-themes/src/test/java/com/vaadin/flow/uitest/ui/theme/ThemeIT.java
Outdated
Show resolved
Hide resolved
mshabarov
reviewed
Apr 21, 2021
flow-tests/test-themes/src/test/java/com/vaadin/flow/uitest/ui/theme/ThemeIT.java
Outdated
Show resolved
Hide resolved
mshabarov
approved these changes
Apr 21, 2021
|
@caalador I've added |
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Iteration Reviews
to Done - pending release
Apr 21, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 21, 2021
If a resource is not found in themes folder check also any assets that are copied for the theme. Fixes #10426
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 21, 2021
If a resource is not found in themes folder check also any assets that are copied for the theme. Fixes #10426
vaadin-bot
added a commit
that referenced
this pull request
Apr 21, 2021
vaadin-bot
added a commit
that referenced
this pull request
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a resource is not found in themes folder
check also any assets that are copied for
the theme.
fixes #10426