Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use global node and tools if they are available first (#10753) (CP: 2.6) #10770

Merged
merged 1 commit into from
Apr 29, 2021
Merged

fix: use global node and tools if they are available first (#10753) (CP: 2.6) #10770

merged 1 commit into from
Apr 29, 2021

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@vaadin-bot
Copy link
Collaborator Author

SonarQube analysis reported 17 issues

  • CRITICAL 1 critical
  • MAJOR 6 major
  • MINOR 10 minor

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL TaskRunNpmInstall.java#L310: Reduce the number of conditional operators (4) used in the expression (maximum allowed 3). rule
  2. MAJOR DevModeHandler.java#L452: Refactor this method to reduce its Cognitive Complexity from 21 to the 15 allowed. rule
  3. MAJOR DevModeHandler.java#L457: Invoke method(s) only conditionally. rule
  4. MAJOR DevModeHandler.java#L459: Invoke method(s) only conditionally. rule
  5. MAJOR DevModeHandler.java#L461: Invoke method(s) only conditionally. rule
  6. MAJOR DevModeHandler.java#L672: Invoke method(s) only conditionally. rule
  7. MAJOR DevModeHandler.java#L683: Either re-interrupt this method or rethrow the "InterruptedException". rule
  8. MINOR FrontendTools.java#L94: Remove this use of "SUPPORTED_NODE_MAJOR_VERSION"; it is deprecated. rule
  9. MINOR FrontendTools.java#L95: Remove this use of "SUPPORTED_NODE_MINOR_VERSION"; it is deprecated. rule
  10. MINOR FrontendTools.java#L96: Remove this use of "SUPPORTED_NPM_MAJOR_VERSION"; it is deprecated. rule

@manolo manolo merged commit 3d6b009 into 2.6 Apr 29, 2021
@manolo manolo deleted the cherry-pick-10753-to-2.6-1619075453062 branch April 29, 2021 14:25
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with platform 14.6.0.rc1. For prerelease versions, it will be included in its final version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manolo manolo manolo approved these changes

Assignees
No one assigned
Labels
prerelease version for platform 14.6.0 Released with Platform 14.6.0.rc1 +0.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vaadin-bot @manolo