Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extend and clarify valid tag names #10801

Merged
merged 1 commit into from Apr 26, 2021
Merged

Conversation

denis-anisimov
Copy link
Contributor

fixes #9669

@caalador caalador enabled auto-merge (squash) April 26, 2021 10:23
@caalador caalador merged commit 76ce842 into master Apr 26, 2021
@caalador caalador deleted the 9669-element-tag-name branch April 26, 2021 10:58
OLD Vaadin Flow bugs & maintenance (Vaadin 10+) automation moved this from WIP to Closed Apr 26, 2021
vaadin-bot pushed a commit that referenced this pull request Apr 26, 2021
vaadin-bot pushed a commit that referenced this pull request Apr 26, 2021
vaadin-bot pushed a commit that referenced this pull request Apr 26, 2021
vaadin-bot added a commit that referenced this pull request Apr 26, 2021
fixes #9669

Co-authored-by: Denis <denis@vaadin.com>
vaadin-bot added a commit that referenced this pull request Apr 26, 2021
fixes #9669

Co-authored-by: Denis <denis@vaadin.com>
vaadin-bot added a commit that referenced this pull request Apr 26, 2021
fixes #9669

Co-authored-by: Denis <denis@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 20.0.0.alpha8. For prerelease versions, it will be included in its final version.

@vaadin-bot
Copy link
Collaborator

Hi @denis-anisimov , this commit cannot be picked to 6.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 76ce842
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

git commit --allow-empty

Otherwise, please use 'git reset'

@vaadin-bot
Copy link
Collaborator

Hi @denis-anisimov , this commit cannot be picked to 2.6 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 76ce842
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

git commit --allow-empty

Otherwise, please use 'git reset'

@vaadin-bot
Copy link
Collaborator

Hi @denis-anisimov , this commit cannot be picked to 2.5 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 76ce842
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

git commit --allow-empty

Otherwise, please use 'git reset'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Unable to use an element with _ in the tag name
3 participants