-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: revert "feat: use superclass of VaadinServlet/Request (#9699)" #10812
Conversation
flow-server/src/main/java/com/vaadin/flow/server/StaticFileServer.java
Outdated
Show resolved
Hide resolved
Fixes review comment and broken compilation.
flow-server/src/main/java/com/vaadin/flow/server/communication/PushHandler.java
Show resolved
Hide resolved
I'll fix the commit message, the This part is reverted for now. |
SonarQube analysis reported 6 issues Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
This reverts commit c581668, except
intentionally leaves out the protected API introduced to StaticFileServer to get a static
resource, so it may be overridden to use something else than VaadinServletService.