Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to LitElement 2.5.0 and lit-html 1.4.0 #10874

Merged
merged 1 commit into from May 3, 2021
Merged

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented May 3, 2021

Description

Upgrades to LitElement 2.5 which is forward compatible with LitElement 3 aka Lit 2
Fixes #10826

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 1 issue

  1. CRITICAL NodeUpdater.java#L284: Either log or rethrow this exception. rule

@Haprog Haprog merged commit f0ebed6 into master May 3, 2021
@Haprog Haprog deleted the upgrade-litelement-25 branch May 3, 2021 11:27
@vaadin-bot
Copy link
Collaborator

Hi @Artur- , this commit cannot be picked to 6.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick f0ebed6
error: could not apply f0ebed6... fix: upgrade to LitElement 2.5.0 and lit-html 1.4.0 (#10874)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot
Copy link
Collaborator

Hi @Artur- , this commit cannot be picked to 2.6 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick f0ebed6
error: could not apply f0ebed6... fix: upgrade to LitElement 2.5.0 and lit-html 1.4.0 (#10874)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot
Copy link
Collaborator

Hi @Artur- , this commit cannot be picked to 2.5 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick f0ebed6
error: could not apply f0ebed6... fix: upgrade to LitElement 2.5.0 and lit-html 1.4.0 (#10874)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to LitElement 2.5 once available
3 participants