Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade to LitElement 2.5.1 and lit-html 1.4.1 #10912

Merged
merged 1 commit into from May 6, 2021
Merged

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented May 6, 2021

No description provided.

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 1 issue

  1. CRITICAL NodeUpdater.java#L284: Either log or rethrow this exception. rule

@vaadin-bot
Copy link
Collaborator

Hi @Artur- , this commit cannot be picked to 2.6 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 8562697
error: could not apply 8562697... fix: upgrade to LitElement 2.5.1 and lit-html 1.4.1 (#10912)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@vaadin-bot
Copy link
Collaborator

Hi @Artur- , this commit cannot be picked to 2.5 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 8562697
error: could not apply 8562697... fix: upgrade to LitElement 2.5.1 and lit-html 1.4.1 (#10912)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

vaadin-bot added a commit that referenced this pull request May 6, 2021
@knoobie
Copy link
Contributor

knoobie commented May 10, 2021

@Artur- looks like this is missing in the latest 2.5.4 release: https://github.com/vaadin/flow/releases/tag/2.5.4

@Haprog
Copy link
Contributor

Haprog commented May 10, 2021

Looks like this hasn't been cherry-picked to 2.5 yet (only to 2.6 and 6.0 so far).

@Haprog
Copy link
Contributor

Haprog commented May 10, 2021

@knoobie I think this won't make it to 2.5 anymore. Vaadin 14.6.0 LTS (with Flow 2.6 containing this fix) should be out in a few days so you can upgrade to that.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 20.0.0.beta2. For prerelease versions, it will be included in its final version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants