Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Fusion): binding nullable fields with combo-box throws when clearing #10954

Merged
merged 1 commit into from
May 10, 2021
Merged

fix(Fusion): binding nullable fields with combo-box throws when clearing #10954

merged 1 commit into from
May 10, 2021

Conversation

platosha
Copy link
Contributor

Fixes #10848

@platosha platosha added the hilla Issues related to Hilla label May 10, 2021
@platosha platosha marked this pull request as ready for review May 10, 2021 07:04
haijian-vaadin
haijian-vaadin reviewed May 10, 2021
View reviewed changes
Copy link
Contributor

@haijian-vaadin haijian-vaadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but needs a rebase to master which fixes the lint error

@platosha platosha force-pushed the fix/ap/nullable-combo-box-clear branch from 1f18feb to 149b6d6 Compare May 10, 2021 11:59
@platosha
Copy link
Contributor Author

@haijian-vaadin rebased

@haijian-vaadin haijian-vaadin enabled auto-merge (squash) May 10, 2021 12:22
@haijian-vaadin haijian-vaadin merged commit a81fe3c into master May 10, 2021
@haijian-vaadin haijian-vaadin deleted the fix/ap/nullable-combo-box-clear branch May 10, 2021 12:53
vaadin-bot pushed a commit that referenced this pull request May 10, 2021
@platosha @vaadin-bot
fix(Fusion): binding nullable fields with combo-box throws when clear…
9d673cd 
…ing (#10954)

Fixes #10848
vaadin-bot pushed a commit that referenced this pull request May 10, 2021
@platosha @vaadin-bot
fix(Fusion): binding nullable fields with combo-box throws when clear…
99e667d 
…ing (#10954)

Fixes #10848
vaadin-bot added a commit that referenced this pull request May 11, 2021
@vaadin-bot @platosha @caalador
fix(Fusion): binding nullable fields with combo-box throws when clear…
1656620 
…ing (#10954) (#10966)

Fixes #10848

Co-authored-by: Anton Platonov <anton@vaadin.com>
Co-authored-by: Mikael Grankvist <mikael.grankvist@vaadin.com>
vaadin-bot added a commit that referenced this pull request May 11, 2021
@vaadin-bot @platosha @caalador
fix(Fusion): binding nullable fields with combo-box throws when clear…
debf8cd 
…ing (#10954) (#10967)

Fixes #10848

Co-authored-by: Anton Platonov <anton@vaadin.com>
Co-authored-by: Mikael Grankvist <mikael.grankvist@vaadin.com>
Artur- pushed a commit that referenced this pull request May 18, 2021
@platosha @Artur-
fix(Fusion): binding nullable fields with combo-box throws when clear…
134b111 
…ing (#10954)

Fixes #10848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haijian-vaadin haijian-vaadin haijian-vaadin approved these changes

Assignees
No one assigned
Labels
cherry-picked-6.0 cherry-picked-7.0 hilla Issues related to Hilla +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on clearing the combobox field
3 participants
@platosha @haijian-vaadin @vaadin-bot