Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Annotate default error handlers. (#11063) (#11089) (CP: 2.6) #11092

Merged
merged 1 commit into from
May 27, 2021
Merged

fix: Annotate default error handlers. (#11063) (#11089) (CP: 2.6) #11092

merged 1 commit into from
May 27, 2021

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@caalador @vaadin-bot
fix: Annotate default error handlers. (#11063) (#11089)
387c306 
Annotate default error handlers with
the new annotaton DefaultErrorHandler
so that we can also in add-ons have default
handlers that can be overridden by user
handlers.

Part of vaadin/spring#661
@vaadin-bot
Copy link
Collaborator Author

SonarQube analysis reported 4 issues

  1. CRITICAL ApplicationRouteRegistry.java#L49: Remove this unused import 'com.vaadin.flow.router.internal.RouteTarget'. rule
  2. MINOR ApplicationRouteRegistry.java#L115: This call to "add()" may be a performance hot spot if the collection is large. rule
  3. INFO AbstractRouteRegistry.java#L271: Do not forget to remove this deprecated code someday. rule
  4. INFO ApplicationRouteRegistry.java#L259: Do not forget to remove this deprecated code someday. rule

pleku
pleku approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@pleku pleku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for maintenance release since it adds only API that is considered internal.

@pleku pleku merged commit 2a25583 into 2.6 May 27, 2021
@pleku pleku deleted the cherry-pick-11089-to-2.6-1622104568690 branch May 27, 2021 11:54
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with platform 14.6.2. For prerelease versions, it will be included in its final version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleku pleku pleku approved these changes

Assignees
No one assigned
Labels
Released with Platform 14.6.2 +0.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaadin-bot @pleku @caalador