Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid NPE in LookupServletContainerInitializer (#11233) (CP: 2.6) #11238

Merged
merged 1 commit into from
Jun 15, 2021
Merged

fix: avoid NPE in LookupServletContainerInitializer (#11233) (CP: 2.6) #11238

merged 1 commit into from
Jun 15, 2021

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@vaadin-bot
Copy link
Collaborator Author

SonarQube analysis reported 2 issues

  1. MAJOR LookupServletContainerInitializer.java#L97: "servletContext" is a method parameter, and should not be used for synchronization. rule
  2. MINOR LookupServletContainerInitializer.java#L193: Replace this if-then-else statement by a single return statement. rule

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically.[Message is sent from bot]

@vaadin-bot vaadin-bot merged commit e1956ff into 2.6 Jun 15, 2021
@vaadin-bot
Copy link
Collaborator Author

This PR has been merged with 'squash' method.[Message is sent from bot]

@vaadin-bot vaadin-bot deleted the cherry-pick-11233-to-2.6-1623747329303 branch June 15, 2021 09:45
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with platform 14.6.4. For prerelease versions, it will be included in its final version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaadin-review-bot vaadin-review-bot vaadin-review-bot approved these changes

Assignees
No one assigned
Labels
Released with Platform 14.6.4 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vaadin-bot @vaadin-review-bot