Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not open FileSystem for unknown schemes (#11235) (#11253) (CP: 7.0) #11265

Merged
merged 2 commits into from
Jun 18, 2021
Merged

fix: do not open FileSystem for unknown schemes (#11235) (#11253) (CP: 7.0) #11265

merged 2 commits into from
Jun 18, 2021

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@caalador @vaadin-bot
fix: do not open FileSystem for unknown schemes (#11235) (#11253)
a46d3df 
Don't open a filesystem for unknown schemes
that are probably custom for container and
have no FileSystem Provider implementation added.

Fixes #11230
@caalador
Fix registering multiple fatories in tests
f0cb46d
@vaadin-bot
Copy link
Collaborator Author

SonarQube analysis reported 3 issues

  1. MAJOR StaticFileServer.java#L160: Replace this with a call to the "toFile().isDirectory()" method rule
  2. MAJOR StaticFileServer.java#L170: Replace this with a call to the "toFile().isDirectory()" method rule
  3. MINOR StaticFileServer.java#L211: Move the "file" string literal on the left side of this string comparison. rule

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically.[Message is sent from bot]

@vaadin-bot vaadin-bot merged commit 1672eaf into 7.0 Jun 18, 2021
@vaadin-bot
Copy link
Collaborator Author

This PR has been merged with 'squash' method.[Message is sent from bot]

@vaadin-bot vaadin-bot deleted the cherry-pick-11253-to-7.0-1623912297195 branch June 18, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaadin-review-bot vaadin-review-bot vaadin-review-bot approved these changes

Assignees
No one assigned
Labels
+0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaadin-bot @vaadin-review-bot @caalador