fix: Don't revisit visited classes. #11447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not revisit visited classes as visited childer will not be rechecked and possibly overwriten. Always visit UI once as else we get UI JsModule in fallback. Fixes #9861
caalador
added this to Iteration Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
via automation
caalador
force-pushed
the
issues/9861_dependency_scanning
branch
from
5c7bc96
to
f946ead
Compare
caalador
force-pushed
the
issues/9861_dependency_scanning
branch
from
74bf5d1
to
e9c03b9
Compare
|
SonarQube analysis reported 1 issue
|
denis-anisimov
approved these changes
Jul 21, 2021
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Iteration Reviews
to Done - pending release
Jul 21, 2021
|
This ticket/PR has been released with platform 22.0.0.alpha1 and is also targeting the upcoming stable 22.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not revisit visited classes as
visited childer will not be rechecked
and possibly overwriten.
Always visit UI once as else we get
UI JsModule in fallback.
Fixes #9861