Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use byte[] instead of String to store stats.json #11516

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Conversation

TatuLund
Copy link
Contributor

@TatuLund TatuLund commented Aug 3, 2021

This is made to avoid excessive memory usage when managing the data

fixes: #11515

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 3 issues

  1. MINOR FrontendUtils.java#L482: Remove this use of "closeQuietly"; it is deprecated. rule
  2. MINOR FrontendUtils.java#L536: Remove this use of "closeQuietly"; it is deprecated. rule
  3. INFO FrontendUtils.java#L168: Do not forget to remove this deprecated code someday. rule

@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Aug 4, 2021
@mshabarov mshabarov merged commit 8412449 into master Aug 6, 2021
@mshabarov mshabarov deleted the fix11514 branch August 6, 2021 07:16
vaadin-bot pushed a commit that referenced this pull request Aug 6, 2021
This is made to avoid excessive memory usage when managing the data.

fixes: #11515
@vaadin-bot
Copy link
Collaborator

Hi @TatuLund and @mshabarov, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 8412449
error: could not apply 8412449... fix: Use byte[] instead of String to store stats.json (#11516)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

vaadin-bot pushed a commit that referenced this pull request Aug 6, 2021
This is made to avoid excessive memory usage when managing the data.

fixes: #11515
@vaadin-bot
Copy link
Collaborator

Hi @TatuLund and @mshabarov, when i performed cherry-pick to this commit to 2.6, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 8412449
error: could not apply 8412449... fix: Use byte[] instead of String to store stats.json (#11516)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@TatuLund
Copy link
Contributor Author

TatuLund commented Aug 6, 2021

@mshabarov here: #11529

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha1 and is also targeting the upcoming stable 22.0.0 version.

vaadin-bot added a commit that referenced this pull request Aug 9, 2021
This is made to avoid excessive memory usage when managing the data.

fixes: #11515

Co-authored-by: Tatu Lund <tatu@vaadin.com>
Co-authored-by: Mikhail Shabarov <mikhail@vaadin.com>
vaadin-bot added a commit that referenced this pull request Aug 9, 2021
This is made to avoid excessive memory usage when managing the data.

fixes: #11515

Co-authored-by: Tatu Lund <tatu@vaadin.com>
Co-authored-by: Mikhail Shabarov <mikhail@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inefficient handling of stats.json
4 participants