Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set Vaadin session attribute using lock #11538

Merged
merged 1 commit into from Aug 9, 2021
Merged

fix: set Vaadin session attribute using lock #11538

merged 1 commit into from Aug 9, 2021

Conversation

denis-anisimov
Copy link
Contributor

@denis-anisimov denis-anisimov commented Aug 9, 2021 •
edited

fixes #11519

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 4 issues

  1. MAJOR VaadinService.java#L392: Rename "instantiator" which hides the field declared at line 192. rule
  2. MINOR VaadinService.java#L333: Replace this lambda with a method reference. rule
  3. MINOR VaadinService.java#L395: Remove this use of "init"; it is deprecated. rule
  4. MINOR VaadinService.java#L409: Remove this use of "init"; it is deprecated. rule

@pleku pleku self-requested a review August 9, 2021 11:06
@denis-anisimov denis-anisimov changed the title fix: set Vaadin session attriute using lock fix: set Vaadin session attribute using lock Aug 9, 2021
@pleku pleku added +0.0.1 and removed +0.1.0 labels Aug 9, 2021
@pleku pleku merged commit 188fcae into master Aug 9, 2021
OLD Vaadin Flow bugs & maintenance (Vaadin 10+) automation moved this from WIP to Closed Aug 9, 2021
@pleku pleku deleted the 11519-reinit-session branch August 9, 2021 12:11
vaadin-bot pushed a commit that referenced this pull request Aug 9, 2021
@vaadin-bot
fix: set Vaadin session attribute using lock (#11538)
f4b0c2e 
Fixes #11519
vaadin-bot pushed a commit that referenced this pull request Aug 9, 2021
@vaadin-bot
fix: set Vaadin session attribute using lock (#11538)
1869bfd 
Fixes #11519
vaadin-bot pushed a commit that referenced this pull request Aug 9, 2021
@vaadin-bot
fix: set Vaadin session attribute using lock (#11538)
f855414 
Fixes #11519
vaadin-bot pushed a commit that referenced this pull request Aug 9, 2021
@vaadin-bot
fix: set Vaadin session attribute using lock (#11538)
a43cbdb 
Fixes #11519
vaadin-bot added a commit that referenced this pull request Aug 9, 2021
@vaadin-bot
fix: set Vaadin session attribute using lock (#11538) (#11543)
16dd559 
Fixes #11519

Co-authored-by: Denis <denis@vaadin.com>
vaadin-bot added a commit that referenced this pull request Aug 9, 2021
@vaadin-bot
fix: set Vaadin session attribute using lock (#11538) (#11541)
ad5f5df 
Fixes #11519

Co-authored-by: Denis <denis@vaadin.com>
vaadin-bot added a commit that referenced this pull request Aug 9, 2021
@vaadin-bot
fix: set Vaadin session attribute using lock (#11538) (#11542)
33ba55a 
Fixes #11519

Co-authored-by: Denis <denis@vaadin.com>
vaadin-bot added a commit that referenced this pull request Aug 9, 2021
@vaadin-bot
fix: set Vaadin session attribute using lock (#11538) (#11544)
5302a3d 
Fixes #11519

Co-authored-by: Denis <denis@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.0.alpha2 and is also targeting the upcoming stable 22.0.0 version.

TatuLund added a commit to vaadin/framework that referenced this pull request Sep 15, 2021
@TatuLund
Cherry picked unit test from Flow
a9beec0 
See vaadin/flow#11538
@TatuLund TatuLund mentioned this pull request Sep 15, 2021
Merged
OlliTietavainenVaadin pushed a commit to vaadin/framework that referenced this pull request Sep 16, 2021
@TatuLund
fix: set Vaadin session attribute using lock in reinitializeSession (#…
ba5e586 
…12401)

* Cherry picked unit test from Flow

See vaadin/flow#11538

* Fix missing import

* Cherry pick fix from Flow
OlliTietavainenVaadin pushed a commit to OlliTietavainenVaadin/framework that referenced this pull request Oct 5, 2021
@TatuLund @OlliTietavainenVaadin
fix: set Vaadin session attribute using lock in reinitializeSession (v…
c8d2b7a 
…aadin#12401)

* Cherry picked unit test from Flow

See vaadin/flow#11538

* Fix missing import

* Cherry pick fix from Flow
TatuLund added a commit to vaadin/framework that referenced this pull request Oct 5, 2021
@OlliTietavainenVaadin @TatuLund
@Ansku @ZheSun88 @mshabarov
8.14 cherry-picks (#12418)
ab775a3 
* Improve thread safety (#12395)

See: https://vaadin.com/forum/thread/17522264/concurrentmodificationexception-in-vaadin-shared-on-karaf-4-2-x

* Fix incompatible selenium version in test module. (#12397)

* Fixed a dependency version in a karaf test module. (#12399)

* Checkstyle tweaks to DateField widgets. (#12400)

- Added and updated JavaDocs.
- Updated comments.
- Updated to use non-deprecated method calls.
- Removed unnecessary warning suppressions.
- Suppressed warnings for unavoidable deprecation.

* fix: set Vaadin session attribute using lock in reinitializeSession (#12401)

* Cherry picked unit test from Flow

See vaadin/flow#11538

* Fix missing import

* Cherry pick fix from Flow

* deprecate vaadin-snasphots repo (#12405)

* deprecate vaadin-snasphots repo

* Update chrome version to 93

* add more screenshots

* fix: Add MPR UI id request parameter (#12412)

* fix: Add MPR UI id request parameter

Related-to vaadin/multiplatform-runtime#85

* test: Remove redundant non-empty param test

* test: Remove leftovers

* fix: Init window.mprUiId earlier than window.vaadin

* Add missing '='

* Update links shown by license checker (#12402)

vaadin.com/pro does no longer have the info

* fix: Add row limit to DataCommunicator row data requests (#12415)

* Add row limit to DataCommunicator row data requests

* Add missing constant

* Add unit test

* Add test for extending Grid

* Fixed test

Co-authored-by: Tatu Lund <tatu@vaadin.com>
Co-authored-by: Anna Koskinen <Ansku@users.noreply.github.com>
Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com>
Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleku pleku pleku approved these changes

Assignees
No one assigned
Labels
cherry-picked-2.7 cherry-picked-7.0 cherry-picked-8.0 prerelease version for platform 22.0.0 Released with Platform 22.0.0.alpha2 +0.0.1
Projects
OLD Vaadin Flow bugs & maintenance (V...
Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VaadinService.reinitializeSession doesn't lock sessions properly
3 participants
@denis-anisimov @vaadin-bot @pleku