Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Component.isAttached(). (#8810) #11601

Merged
merged 2 commits into from
Aug 19, 2021
Merged

feat: Implement Component.isAttached(). (#8810) #11601

merged 2 commits into from
Aug 19, 2021

Conversation

caalador
Copy link
Contributor

Closes #7911

@mvysny @caalador
#7911 Implement Component.isAttached(). (#8810)
b1ad691 
Closes #7911
# Conflicts:
#	flow-server/src/test/java/com/vaadin/flow/component/ComponentTest.java
@caalador caalador added this to Iteration Reviews in OLD Vaadin Flow ongoing work (Vaadin 10+) via automation Aug 19, 2021
@CLAassistant
Copy link

CLAassistant commented Aug 19, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@caalador caalador changed the title #7911 Implement Component.isAttached(). (#8810) feat: Implement Component.isAttached(). (#8810) Aug 19, 2021
@caalador @pleku
Add since
ec8fbe0 
Co-authored-by: Pekka Hyvönen <pekka@vaadin.com>
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 2 issues

  1. MINOR Component.java#L152: Remove this use of "addSynchronizedProperty"; it is deprecated. rule
  2. MINOR Component.java#L155: Remove this use of "addSynchronizedPropertyEvent"; it is deprecated. rule

@pleku pleku merged commit 6e431d8 into 2.7 Aug 19, 2021
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Iteration Reviews to Done - pending release Aug 19, 2021
@pleku pleku deleted the cherry/cherrypick-8810-to-2.7 branch August 19, 2021 11:00
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.7.0.rc1 and is also targeting the upcoming stable 14.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleku pleku pleku approved these changes

Assignees
No one assigned
Labels
cherry pick prerelease version for platform 14.7.0 Released with Platform 14.7.0.rc1 +0.1.0
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@caalador @CLAassistant @vaadin-bot @pleku @mvysny