Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement toString, equals, hashCode for Key implementation used… #11837

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

denis-anisimov
Copy link
Contributor

… in "of"

fixes #8474 and #4626

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 1 issue

  1. MAJOR Key.java#L2729: Reduce this anonymous class number of lines from 32 to at most 20, or make it a named class. rule

@vaadin-bot
Copy link
Collaborator

Hi @denis-anisimov and @caalador, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick b6cf0b5
error: could not apply b6cf0b5... fix: implement toString, equals, hashCode for Key implementation used in "of" (#11837)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

vaadin-bot pushed a commit that referenced this pull request Sep 16, 2021
vaadin-bot added a commit that referenced this pull request Sep 16, 2021
… in "of" (#11837) (#11875)

fixes #8474 and #4626

Co-authored-by: Denis <denis@vaadin.com>
vaadin-bot added a commit that referenced this pull request Sep 16, 2021
… in "of" (#11837) (#11876)

fixes #8474 and #4626

Co-authored-by: Denis <denis@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add proper Key.toString() implementation
4 participants